Fixes missing destroyed submodels from the polymodel_instance rendering commit.#496
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
This comment is now incorrect and should be fixed to explain the new behavior instead of the old.
…NO_DISAPPEAR functionality.
Contributor
Author
|
It's removed. |
Member
|
Code looks good and a quick test has shown that the bug has been fixed. |
asarium
added a commit
that referenced
this pull request
Dec 9, 2015
Fixes missing destroyed submodels from the polymodel_instance rendering commit.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #489. Does a minor change to
model_set_instanceso we don't irrevocably alterbsp_info::my_replacementwheneverSSF_NO_DISAPPEARis on while still offering the same functionality; whatevermodel_load()reads in should be expected to be preserved.