Skip to content

Multi host settings API#6073

Closed
MjnMixael wants to merge 14 commits into
scp-fs2open:masterfrom
MjnMixael:multi_host_settings
Closed

Multi host settings API#6073
MjnMixael wants to merge 14 commits into
scp-fs2open:masterfrom
MjnMixael:multi_host_settings

Conversation

@MjnMixael

@MjnMixael MjnMixael commented Mar 30, 2024

Copy link
Copy Markdown
Contributor

Setting as draft for now because I still need to wire up and test several of these methods.. but if someone more familiar with the multi code wanted to give it a preliminary look, that'd be helpful.

EDIT: I should add that I intentionally left voice settings out. They can be added once voice transmission is fully implemented again.

@MjnMixael MjnMixael marked this pull request as draft March 30, 2024 03:04
(cherry picked from commit bcb31c327653329e62e4430815fe1e981751f9dc)
@MjnMixael MjnMixael force-pushed the multi_host_settings branch from 11c287f to e1eec99 Compare March 30, 2024 03:06
@wookieejedi wookieejedi added enhancement A new feature or upgrade of an existing feature to add additional functionality. multi A feature or issue related to the multiplayer code. ui A feature or issue specific to the menus portion of the user interface scripting A feature or issue related to LUA scripting labels Mar 30, 2024
@MjnMixael MjnMixael marked this pull request as ready for review March 30, 2024 21:31
@MjnMixael

Copy link
Copy Markdown
Contributor Author

Everything's tested and seems to work. Ready for review.

@MjnMixael MjnMixael mentioned this pull request Apr 1, 2024
@MjnMixael MjnMixael force-pushed the multi_host_settings branch from 3430594 to 2411fd2 Compare April 1, 2024 17:03
@notimaginative

Copy link
Copy Markdown
Contributor

I should have probably done the reviews in the correct order, but I didn't. So I reviewed #6077 first and it just has most the same stuff here. Same issues too. So would you prefer that I redo those comments here, or can you sort that out?

@MjnMixael

Copy link
Copy Markdown
Contributor Author

I should have probably done the reviews in the correct order, but I didn't. So I reviewed #6077 first and it just has most the same stuff here. Same issues too. So would you prefer that I redo those comments here, or can you sort that out?

No worries. I can sort that out.

@MjnMixael

Copy link
Copy Markdown
Contributor Author

#6077 is identical to this PR but with some additional API code for Multi Sync so all of those requested changes have been applied here as well.

@MjnMixael

Copy link
Copy Markdown
Contributor Author

#6077 includes all of this PR and then some so I'm just gonna close this one

@MjnMixael MjnMixael closed this Apr 2, 2024
@MjnMixael MjnMixael deleted the multi_host_settings branch April 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A new feature or upgrade of an existing feature to add additional functionality. multi A feature or issue related to the multiplayer code. scripting A feature or issue related to LUA scripting ui A feature or issue specific to the menus portion of the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants