Multi sync API#6077
Merged
Merged
Conversation
(cherry picked from commit bcb31c327653329e62e4430815fe1e981751f9dc)
(cherry picked from commit fcde973)
notimaginative
requested changes
Apr 2, 2024
(cherry picked from commit ecb33e7)
notimaginative
approved these changes
Apr 2, 2024
wookieejedi
added
enhancement
# Conflicts: # code/scripting/api/libs/ui.cpp # code/scripting/api/objs/enums.cpp # code/scripting/api/objs/enums.h # code/scripting/api/objs/multi_objects.cpp
notimaginative
added a commit
to notimaginative/fs2open.github.com
that referenced
this pull request
Jul 25, 2025
A minor bug in scp-fs2open#6077 resulted in a crash loading campaigns on the multi ui. The bug itself was not fatal, however it triggered a cascade of poor error handling which led to a crash. A lot of these issues date back to retail. This fixes the minor bug, and hopefully adds enough error handling to preemptively squash a repeat of the crash problem.
notimaginative
added a commit
that referenced
this pull request
Jul 26, 2025
A minor bug in #6077 resulted in a crash loading campaigns on the multi ui. The bug itself was not fatal, however it triggered a cascade of poor error handling which led to a crash. A lot of these issues date back to retail. This fixes the minor bug, and hopefully adds enough error handling to preemptively squash a repeat of the crash problem.
Kestrellius
pushed a commit
to Kestrellius/fs2open.github.com
that referenced
this pull request
Jul 26, 2025
A minor bug in scp-fs2open#6077 resulted in a crash loading campaigns on the multi ui. The bug itself was not fatal, however it triggered a cascade of poor error handling which led to a crash. A lot of these issues date back to retail. This fixes the minor bug, and hopefully adds enough error handling to preemptively squash a repeat of the crash problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods for the SCPUI Multi Sync API. Relies on #6073, so probably best to wait until that is merged to review this one.
#6073 is included in this one, so I closed it. Merging this will get both.