Show team colors with Lua rendering methods#6802
Merged
Merged
Conversation
MjnMixael
added
the
Requested by Active Mod
wookieejedi
approved these changes
Jul 8, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Looks straightforward and tests report work as expected
Member
|
Will plan to merge this in a day or so pending no other reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to get a parsed object's team color setting and then update the various Lua rendering methods to enforce showing a specific team color if desired. This will allow SCPUI's ship/weapon select to respect the team color settings from the mission designer.
I have stubbed in being able to set team colors in the parsed object but I need to do more research into when that's actually applied to the ships created in the mission and I just don't have enough time for that today so that'll be a follow up.