Get, set, browse team colors with Lua#6832
Merged
JohnAFernandez merged 2 commits intoJul 26, 2025
Merged
Conversation
JohnAFernandez
approved these changes
Jul 24, 2025
JohnAFernandez
left a comment
Contributor
There was a problem hiding this comment.
This is actually pretty straightforward. It looks big, but it's mostly just changing to object instead of strings.
Member
|
Will plan to merge this later today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper follow-up to #6802 which was a quick and dirty way to get the basic features BtA wanted in 25.0.0. Since the feature freeze still hasn't started and I'm back from 2 weeks of vacation, here's a proper follow-up that fully implements Team Colors in Lua. Browse available colors in
tb.TeamColorswith the following members.ParsedObjects and Ships can get and set the team color (the latter is instant. A FUNC would be needed to allow the fade, but there's already a SEXP for that so I opted to skip it for now).
The render methods now take a team color object rather than a team color string name. Since this has only been in the API for a few days, I'm thinking this is an ok change.
EDIT: I'm hopeful this can make the 25.0.0 cut for BtA.