make legacy particle spews more robust#7023
Merged
Merged
Conversation
If a pspew specifies a single-frame image, be sure that it is loaded correctly. Fixes a particle crash in Inferno.
Goober5000
added
fix
BMagnu
approved these changes
Sep 7, 2025
wookieejedi
added a commit
to wookieejedi/fs2open.github.com
that referenced
this pull request
Sep 17, 2025
From Sept 15 onward in fast debug I hit this error when using weapon create ASSERTION: "cur_frame < part->nframes" at particle.cpp:371 Assert: "cur_frame < part->nframes" File: particle.cpp Line: 371 Thanks to lafiel, `that assert should have an `|| (part->nframes == 0 && cur_frame == 0) appended beaause while we need to stay inbounds for animations, frame 0 for both is valid for static images`
BMagnu
pushed a commit
that referenced
this pull request
Sep 17, 2025
From Sept 15 onward in fast debug I hit this error when using weapon create ASSERTION: "cur_frame < part->nframes" at particle.cpp:371 Assert: "cur_frame < part->nframes" File: particle.cpp Line: 371 Thanks to lafiel, `that assert should have an `|| (part->nframes == 0 && cur_frame == 0) appended beaause while we need to stay inbounds for animations, frame 0 for both is valid for static images`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a pspew specifies a single-frame image, be sure that it is loaded correctly. Fixes a particle crash in Inferno.