Skip to content

Update to #7023#7042

Merged
BMagnu merged 1 commit into
scp-fs2open:masterfrom
wookieejedi:fix-1-frame-particle-assert
Sep 17, 2025
Merged

Update to #7023#7042
BMagnu merged 1 commit into
scp-fs2open:masterfrom
wookieejedi:fix-1-frame-particle-assert

Conversation

@wookieejedi

Copy link
Copy Markdown
Member

From Sept 15 onward in fast debug I hit this error when using weapon create ASSERTION: "cur_frame < part->nframes" at particle.cpp:371

Assert: "cur_frame < part->nframes"
File: particle.cpp
Line: 371

Thanks to lafiel, that assert should have an || (part->nframes == 0 && cur_frame == 0) appended beaause while we need to stay inbounds for animations, frame 0 for both is valid for static images`

From Sept 15 onward in fast debug I hit this error when using weapon create
ASSERTION: "cur_frame < part->nframes" at particle.cpp:371

Assert: "cur_frame < part->nframes"
File: particle.cpp
Line: 371

Thanks to lafiel, `that assert should have an `|| (part->nframes == 0 && cur_frame == 0) appended beaause while we need to stay inbounds for animations, frame 0 for both is valid for static images`
@wookieejedi wookieejedi added fix A fix for bugs, not-a-bugs, and/or regressions. particles An item related to the particle system labels Sep 17, 2025
@BMagnu BMagnu merged commit 58ff297 into scp-fs2open:master Sep 17, 2025
20 checks passed
@wookieejedi wookieejedi deleted the fix-1-frame-particle-assert branch September 17, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix for bugs, not-a-bugs, and/or regressions. particles An item related to the particle system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants