bindata translator improvements (make Ruby code more idiomatic and simpler) - #29
Merged
Merged
Conversation
Owner
|
Thanks for submitting your improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change to the
BDFieldNameTranslator#to_bd_field_namemethod, by making theBD_DICTlookup slightly more idiomatic: instead of usingHash#[]it now usesHash#fetchwith the original name of the lookup key as the default value, meaning that if it doesn't appear in theBD_DICThash, the lookup key will be returned unchanged.To verify that this refactor is functionally equivalent to the original implementation, I have also included a spec for the
BDFieldNameTranslatormodule, which runs "green" on both the master branch, as well as on the feature branch for this pull request.Thanks, @scrapper! 🙏