Skip to content

bindata translator improvements (make Ruby code more idiomatic and simpler) #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scrapper merged 3 commits into from
Jul 28, 2024
Merged

bindata translator improvements (make Ruby code more idiomatic and simpler) #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a361b53
Add RSpec for BDFieldNameTranslator module
pvdb Jul 4, 2024
31231cf
Make the `BD_DICT` lookup more idiomatic
pvdb Jul 4, 2024
db873ab
Fix Ruby filename in copyright message
pvdb Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/fit4ruby/BDFieldNameTranslator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env ruby -w
# encoding: UTF-8
#
# = FitDataRecord.rb -- Fit4Ruby - FIT file processing library for Ruby
# = BDFieldNameTranslator.rb -- Fit4Ruby - FIT file processing library for Ruby
#
# Copyright (c) 2020 by Chris Schlaeger <cs@taskjuggler.org>
#
Expand All @@ -23,11 +23,7 @@ module BDFieldNameTranslator
}

def to_bd_field_name(name)
if (bd_name = BD_DICT[name])
return bd_name
end

name
BD_DICT.fetch(name, name)
end

end
Expand Down
34 changes: 34 additions & 0 deletions spec/BDFieldNameTranslator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#!/usr/bin/env ruby -w
# encoding: UTF-8
#
# = BDFieldNameTranslator_spec.rb -- Fit4Ruby - FIT file processing library for Ruby
#
# Copyright (c) 2014, 2015 by Chris Schlaeger <cs@taskjuggler.org>
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of version 2 of the GNU General Public License as
# published by the Free Software Foundation.
#

$:.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))

require 'fit4ruby/BDFieldNameTranslator'

describe Fit4Ruby::BDFieldNameTranslator do

include described_class

it 'should translate "array" to "_array"' do
expect(to_bd_field_name('array')).to eq('_array')
end

it 'should translate "type" to "_type"' do
expect(to_bd_field_name('type')).to eq('_type')
end

it 'should NOT translate "blegga"' do
expect(to_bd_field_name('blegga')).to eq('blegga')
end

end