Conversation
jonastheis
left a comment
jonastheis
left a comment
There was a problem hiding this comment.
Looks good but would be better to have the explicit option via command line flag to enable empty block production: #282 (comment)
Understood, will do |
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good, thanks for this! I've left one comment inline which I would like clarifcation from @jonastheis on.
As a follow up I think it would be good to introduce an RPC extension that allows us to toggle this setting following the pattern in #289.
jonastheis
left a comment
jonastheis
left a comment
There was a problem hiding this comment.
This CI failure might be a real one: for the docker integration tests we probably need to run the node now with the flag to enable empty blocks specifically.
|
@varun-doshi best to always run |
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
fix lints and then lgtm
3 participants
Fixes #282