feat(admin rpc): add command to enable/disable automatic sequencing#289
Merged
jonastheis merged 10 commits intomainfrom Sep 3, 2025
Merged
feat(admin rpc): add command to enable/disable automatic sequencing#289jonastheis merged 10 commits intomainfrom
jonastheis merged 10 commits intomainfrom
Conversation
frisitano
reviewed
Sep 2, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Looks good. Shall we add an e2e test that invokes these rpc methods and ensures expected behaviour?
frisitano
previously approved these changes
Sep 3, 2025
Collaborator
frisitano
left a comment
frisitano
left a comment
There was a problem hiding this comment.
Left some comments in line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a rollup node RPC namespace and two specific functions to enable/disable sequencing via this new RPC namespace. Based on examples from https://github.com/scroll-tech/reth/blob/scroll/examples/node-custom-rpc/src/main.rs and https://github.com/paritytech/jsonrpsee/blob/master/examples/examples/proc_macro.rs.
Closes #286