Add Encode Decode to ExtrsinicReport and use RawExtrinsicDetails#704
Merged
Conversation
haerdib
changed the title
haerdib
changed the title
haerdib
added
F6-optimization
haerdib
force-pushed
the
bh/397-add-encode
branch
from
95f745f to
fccc026
Compare
remove error changes and fix build clean up add transforming functions remove non-consuming function add comment add encode decode to extrinsicreport impl same functions for both event details and raw event details fix lifetime add metadata check fix clippy use raw events in extrinsic report fix tests one more fix :)
masapr
requested changes
Feb 12, 2024
Collaborator
masapr
left a comment
masapr
left a comment
There was a problem hiding this comment.
Since the reason for this change, is that we want to support serialization/deserialization, I would add a test for that. Then we know this capability will not be removed without a failing test.
Apart from that it looks good to me
masapr
reviewed
Feb 15, 2024
masapr
approved these changes
Feb 15, 2024
Collaborator
masapr
left a comment
masapr
left a comment
There was a problem hiding this comment.
After our discussion, I'd say it's good now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventDetailsas they do not implement codec Decoding / Encoding.RawEventDetailsto allow usage of EventDetails without always holding the full metadataExtrinsicReportto useRawEventDetailsinstead, to make the report smaller. Otherwise, the full metadata would get encoded / decode and moved all the time. I'd rather keep the report small. If needed, one can always transform theRawEventDetailsback toEventDetailscloses #397