fix spelling for OpenSSL in cmake - #434
Closed
MaikeR-TV wants to merge 1 commit into
Closed
Conversation
dkropachev
approved these changes
Apr 1, 2026
Contributor
|
@MaikeR-TV , it needs to be fixed in other places too |
Consistently use the same writing style for cmake module name, as used for the corresponding cmake variables. Thus the cmake code will also work with generated cmake snippets from conan. Rename FindOPENSSL.cmake accordingly.
MaikeR-TV
force-pushed
the
fix_dependencies_cmake_for_openssl
branch
from
April 1, 2026 12:28
8a783d1 to
de8c953
Compare
Contributor
Author
|
I've fixed the failure for Linux by renaming the FindOpenSSL.cmake to FindOPENSSL.cmake accordingly. |
MaikeR-TV
changed the title
dkropachev
requested changes
Apr 1, 2026
dkropachev
left a comment
dkropachev
left a comment
Contributor
There was a problem hiding this comment.
it needs to be updated in other places too
Contributor
Author
dkropachev
added a commit
that referenced
this pull request
Apr 1, 2026
…package call Cherry-picked from PR #434 by MaikeR-TV: - Rename cmake/FindOpenSSL.cmake to cmake/FindOPENSSL.cmake - Change find_package(OpenSSL) to find_package(OPENSSL) in Dependencies.cmake Additionally update find_package_handle_standard_args() calls inside FindOPENSSL.cmake to use OPENSSL (matching the new package name) so CMake sets the correct OPENSSL_FOUND variable.
Contributor
|
@MaikeR-TV , thanks for bring it up and taking your time to fix it, i will take your changes and have some more on top of them in #435 |
dkropachev
added a commit
that referenced
this pull request
Apr 1, 2026
## Summary Rename OpenSSL-related CMake variables and module file to follow the uppercase `OPENSSL_*` naming convention used throughout the build system. ## Context All OpenSSL-related CMake variables in the project use the uppercase `OPENSSL_*` convention (e.g., `OPENSSL_VERSION`, `OPENSSL_INCLUDE_DIR`, `OPENSSL_LIBRARIES`, `CASS_USE_OPENSSL`). However, a few places used inconsistent casing: - The `openssl_name` helper variable used lowercase - The `FindOpenSSL.cmake` module file and its `find_package(OpenSSL)` call used mixed-case Incorporates changes from PR #434 by @MaikeR-TV (file rename + find_package update), with additional fixes for `find_package_handle_standard_args` consistency. ## Changes - Renamed `openssl_name` variable to `OPENSSL_NAME` in `cmake/Dependencies.cmake` and `cmake/FindOPENSSL.cmake` - Renamed `cmake/FindOpenSSL.cmake` to `cmake/FindOPENSSL.cmake` (from PR #434) - Changed `find_package(OpenSSL)` to `find_package(OPENSSL)` in `cmake/Dependencies.cmake` (from PR #434) - Updated all three `find_package_handle_standard_args(OpenSSL ...)` calls to `find_package_handle_standard_args(OPENSSL ...)` so CMake correctly sets `OPENSSL_FOUND` No behavioral changes — all modifications are naming consistency fixes. ## Testing ```bash # Configure cmake -S . -B build -DCMAKE_BUILD_TYPE=Release # Full lint gate make check ``` Both pass successfully. ## Links - Incorporates: #434 - Related macOS CI issue (pre-existing, unrelated): #436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently use the same writing style for cmake module name, as used for the corresponding cmake variables.
Thus the cmake code will also work with generated cmake snippets from conan.
Renaming FindOpenSSL.cmake to FindOPENSSL.cmake accordingly.
Fixes: "Unable to Locate OpenSSL: Third party build step will be performed" when openssl is provided as conan dependency
Pre-review checklist
Makefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.