cmake: uppercase all the OPENSSL variables - #435
Merged
Conversation
…ntion - Rename openssl_name variable to OPENSSL_NAME in Dependencies.cmake and FindOPENSSL.cmake - Rename cmake/FindOpenSSL.cmake to cmake/FindOPENSSL.cmake - Change find_package(OpenSSL) to find_package(OPENSSL) - Update find_package_handle_standard_args() calls to use OPENSSL Co-authored-by: MaikeR-TV <MaikeR-TV@users.noreply.github.com>
dkropachev
force-pushed
the
fix/rename-openssl-cmake-variable
branch
from
April 1, 2026 15:10
a6a60ce to
c43ac4d
Compare
6 tasks
Contributor
Author
|
@Lorak-mmk , @wprzytula , macOS issue fixed here - #437 |
dkropachev
marked this pull request as ready for review
April 1, 2026 16:46
Lorak-mmk
approved these changes
Apr 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename OpenSSL-related CMake variables and module file to follow the uppercase
OPENSSL_*naming convention used throughout the build system.Context
All OpenSSL-related CMake variables in the project use the uppercase
OPENSSL_*convention (e.g.,OPENSSL_VERSION,OPENSSL_INCLUDE_DIR,OPENSSL_LIBRARIES,CASS_USE_OPENSSL). However, a few places used inconsistent casing:openssl_namehelper variable used lowercaseFindOpenSSL.cmakemodule file and itsfind_package(OpenSSL)call used mixed-caseIncorporates changes from PR #434 by @MaikeR-TV (file rename + find_package update), with additional fixes for
find_package_handle_standard_argsconsistency.Changes
openssl_namevariable toOPENSSL_NAMEincmake/Dependencies.cmakeandcmake/FindOPENSSL.cmakecmake/FindOpenSSL.cmaketocmake/FindOPENSSL.cmake(from PR fix spelling for OpenSSL in cmake #434)find_package(OpenSSL)tofind_package(OPENSSL)incmake/Dependencies.cmake(from PR fix spelling for OpenSSL in cmake #434)find_package_handle_standard_args(OpenSSL ...)calls tofind_package_handle_standard_args(OPENSSL ...)so CMake correctly setsOPENSSL_FOUNDNo behavioral changes — all modifications are naming consistency fixes.
Testing
Both pass successfully.
Links