Skip to content

cmake: uppercase all the OPENSSL variables - #435

Merged
dkropachev merged 1 commit into
masterfrom
fix/rename-openssl-cmake-variable
Apr 1, 2026
Merged

cmake: uppercase all the OPENSSL variables#435
dkropachev merged 1 commit into
masterfrom
fix/rename-openssl-cmake-variable

Conversation

@dkropachev

@dkropachev dkropachev commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Rename OpenSSL-related CMake variables and module file to follow the uppercase OPENSSL_* naming convention used throughout the build system.

Context

All OpenSSL-related CMake variables in the project use the uppercase OPENSSL_* convention (e.g., OPENSSL_VERSION, OPENSSL_INCLUDE_DIR, OPENSSL_LIBRARIES, CASS_USE_OPENSSL). However, a few places used inconsistent casing:

  • The openssl_name helper variable used lowercase
  • The FindOpenSSL.cmake module file and its find_package(OpenSSL) call used mixed-case

Incorporates changes from PR #434 by @MaikeR-TV (file rename + find_package update), with additional fixes for find_package_handle_standard_args consistency.

Changes

  • Renamed openssl_name variable to OPENSSL_NAME in cmake/Dependencies.cmake and cmake/FindOPENSSL.cmake
  • Renamed cmake/FindOpenSSL.cmake to cmake/FindOPENSSL.cmake (from PR fix spelling for OpenSSL in cmake #434)
  • Changed find_package(OpenSSL) to find_package(OPENSSL) in cmake/Dependencies.cmake (from PR fix spelling for OpenSSL in cmake #434)
  • Updated all three find_package_handle_standard_args(OpenSSL ...) calls to find_package_handle_standard_args(OPENSSL ...) so CMake correctly sets OPENSSL_FOUND

No behavioral changes — all modifications are naming consistency fixes.

Testing

# Configure
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release

# Full lint gate
make check

Both pass successfully.

Links

…ntion

- Rename openssl_name variable to OPENSSL_NAME in Dependencies.cmake
  and FindOPENSSL.cmake
- Rename cmake/FindOpenSSL.cmake to cmake/FindOPENSSL.cmake
- Change find_package(OpenSSL) to find_package(OPENSSL)
- Update find_package_handle_standard_args() calls to use OPENSSL

Co-authored-by: MaikeR-TV <MaikeR-TV@users.noreply.github.com>
@dkropachev
dkropachev force-pushed the fix/rename-openssl-cmake-variable branch from a6a60ce to c43ac4d Compare April 1, 2026 15:10
@dkropachev dkropachev changed the title cmake: rename openssl_name variable to OPENSSL_NAME cmake: uppercase all the OPENSSL variables Apr 1, 2026
@dkropachev dkropachev mentioned this pull request Apr 1, 2026
6 tasks
@dkropachev dkropachev self-assigned this Apr 1, 2026
@dkropachev

Copy link
Copy Markdown
Contributor Author

@Lorak-mmk , @wprzytula , macOS issue fixed here - #437

@dkropachev
dkropachev marked this pull request as ready for review April 1, 2026 16:46
@dkropachev
dkropachev merged commit 8cc9732 into master Apr 1, 2026
8 of 9 checks passed
@wprzytula wprzytula added this to the 1.1.0 milestone May 25, 2026
@wprzytula wprzytula mentioned this pull request Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants