This repository was archived by the owner on Jan 20, 2026. It is now read-only.
[nice to have] multisig preventing signing with wrong key#286
Merged
BrandonWeng merged 5 commits intomainfrom Jun 14, 2023
Merged
[nice to have] multisig preventing signing with wrong key#286BrandonWeng merged 5 commits intomainfrom
BrandonWeng merged 5 commits intomainfrom
Conversation
alexanderbez
approved these changes
Jun 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 54.98% 54.95% -0.03%
==========================================
Files 619 619
Lines 51524 51549 +25
==========================================
Hits 28329 28329
- Misses 21162 21187 +25
Partials 2033 2033
|
philipsu522
approved these changes
Jun 14, 2023
Contributor
Author
|
Just tested this on a local node too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Doesn't seem to be absolutely necessary since it would just fail when broadcasting, more of an UI improvement. We can wait until 3.0.4 is out and then merging
Copying from: cosmos/cosmos-sdk#12548
Testing performed to validate your change
unit tests