fix: Prevent signing from wrong key in multisig#12548
Merged
julienrbrt merged 7 commits intomainfrom Jul 14, 2022
Merged
Conversation
added 2 commits
July 13, 2022 11:18
…ita/fix-multisig-key-2
Codecov Report
@@ Coverage Diff @@
## main #12548 +/- ##
==========================================
- Coverage 65.23% 65.19% -0.05%
==========================================
Files 693 694 +1
Lines 71798 71893 +95
==========================================
+ Hits 46841 46868 +27
- Misses 22326 22394 +68
Partials 2631 2631
|
likhita-809
requested review from
a team,
JeancarloBarrios,
alexanderbez,
amaury1093,
anilcse,
atheeshp,
julienrbrt and
tac0turtle
amaury1093
approved these changes
Jul 13, 2022
Contributor
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
LGTM, thanks for the explanations in #12446
added 2 commits
July 13, 2022 20:09
…ita/fix-multisig-key-2
Contributor
|
Testing the CLI locally... |
BrandonWeng
added a commit
to sei-protocol/sei-cosmos
that referenced
this pull request
Jun 14, 2023
## Describe your changes and provide context Doesn't seem to be absolutely necessary since it would just fail when broadcasting, more of an UI improvement. We can wait until 3.0.4 is out and then merging Copying from: cosmos/cosmos-sdk#12548 ## Testing performed to validate your change unit tests
5 tasks
5 tasks
masih
pushed a commit
to sei-protocol/sei-chain
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Doesn't seem to be absolutely necessary since it would just fail when broadcasting, more of an UI improvement. We can wait until 3.0.4 is out and then merging Copying from: cosmos/cosmos-sdk#12548 ## Testing performed to validate your change unit tests
masih
pushed a commit
to sei-protocol/sei-chain
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Doesn't seem to be absolutely necessary since it would just fail when broadcasting, more of an UI improvement. We can wait until 3.0.4 is out and then merging Copying from: cosmos/cosmos-sdk#12548 ## Testing performed to validate your change unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12328
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change