Skip to content

Add all-false ViewOptions test object#121

Merged
alex-rawlings-yyc merged 7 commits into
gloss-segmentfrom
gloss-segment-view-options-all-false
Jun 22, 2026
Merged

Add all-false ViewOptions test object#121
alex-rawlings-yyc merged 7 commits into
gloss-segmentfrom
gloss-segment-view-options-all-false

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Devin: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/121

This change is Reviewable

Summary by CodeRabbit

  • Tests

    • Refactored test infrastructure to use a shared helper constant for view options configuration across multiple component tests.
  • Chores

    • Improved test maintainability by centralizing common test data setup.

@imnasnainaec imnasnainaec self-assigned this Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b677b66c-3c1c-4e8a-b602-dc8f87335398

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add all-false ViewOptions test object' accurately describes the main change: introducing a new test helper constant with all ViewOptions flags set to false.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gloss-segment-view-options-all-false

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnasnainaec imnasnainaec force-pushed the gloss-segment-view-options-all-false branch from e3980e5 to c747e4a Compare June 22, 2026 15:49
@imnasnainaec imnasnainaec force-pushed the gloss-segment-view-options-all-false branch from c747e4a to 759196f Compare June 22, 2026 15:50

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-rawlings-yyc reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@alex-rawlings-yyc alex-rawlings-yyc merged commit ef2f6b7 into gloss-segment Jun 22, 2026
2 checks passed
@alex-rawlings-yyc alex-rawlings-yyc deleted the gloss-segment-view-options-all-false branch June 22, 2026 16:01
alex-rawlings-yyc added a commit that referenced this pull request Jun 22, 2026
* Add free translation input to segment view

* Minor adjustments

* Minor adjustment

* Reduce test

* Refine localized-strings tests

* Add all-false ViewOptions test object

---------

Co-authored-by: Alex Rawlings <alex.rawlings@wycliffe.ca>
alex-rawlings-yyc added a commit that referenced this pull request Jun 22, 2026
* Add free translation input to segment view

* Minor adjustments

* Minor adjustment

* Reduce test

* Refine localized-strings tests

* Add all-false ViewOptions test object

---------

Co-authored-by: Alex Rawlings <alex.rawlings@wycliffe.ca>
alex-rawlings-yyc added a commit that referenced this pull request Jun 22, 2026
* Add free translation input to segment view

* Minor adjustments

* Minor adjustment

* Reduce test

* Refine localized-strings tests

* Add all-false ViewOptions test object

---------

Co-authored-by: Alex Rawlings <alex.rawlings@wycliffe.ca>
alex-rawlings-yyc added a commit that referenced this pull request Jun 22, 2026
* Add free translation input to segment view

* Minor adjustments

* Minor adjustment

* Reduce test

* Refine localized-strings tests

* Add all-false ViewOptions test object (#121)

* Add free translation input to segment view

* Minor adjustments

* Minor adjustment

* Reduce test

* Refine localized-strings tests

* Add all-false ViewOptions test object

---------

Co-authored-by: Alex Rawlings <alex.rawlings@wycliffe.ca>

* Adjust docs, add empty multiString helper

---------

Co-authored-by: Danny Rorabaugh <imnasnainaec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants