Skip to content

Add all-false ViewOptions test object #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-rawlings-yyc merged 7 commits into from
Jun 22, 2026
Merged

Add all-false ViewOptions test object #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e6dd6f4
Add free translation input to segment view
alex-rawlings-yyc Jun 18, 2026
a50d6cd
Minor adjustments
alex-rawlings-yyc Jun 19, 2026
caa2dce
Minor adjustment
alex-rawlings-yyc Jun 19, 2026
6cd7801
Reduce test
imnasnainaec Jun 22, 2026
e8d45d2
Refine localized-strings tests
imnasnainaec Jun 22, 2026
b4ef86e
Merge branch 'gloss-segment' of https://github.com/sillsdev/interline…
imnasnainaec Jun 22, 2026
759196f
Add all-false ViewOptions test object
imnasnainaec Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions src/__tests__/components/ContinuousView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type { PhraseDispatch } from '../../components/AnalysisStore';
import ContinuousView from '../../components/ContinuousView';
import { isWordToken } from '../../types/type-guards';
import type { ViewOptions } from '../../types/view-options';
import { withAnalysisStore } from './test-helpers';
import { allFalseViewOptions, withAnalysisStore } from './test-helpers';

// ---------------------------------------------------------------------------
// AnalysisStore mock — pass-through provider so AnalysisStore.tsx stays out of scope
Expand Down Expand Up @@ -431,13 +431,7 @@ function requiredProps(
tokenSegmentMap,
tokenDocOrder,
wordTokenByRef,
viewOptions: {
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
},
viewOptions: { ...allFalseViewOptions },
};
}

Expand Down Expand Up @@ -902,13 +896,7 @@ describe('ContinuousView scroll behavior', () => {
tokenSegmentMap={tokenSegmentMap}
tokenDocOrder={tokenDocOrder}
wordTokenByRef={wordTokenByRef}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>
);
}
Expand Down
121 changes: 16 additions & 105 deletions src/__tests__/components/Interlinearizer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { InterlinearNavProvider } from '../../components/InterlinearNavContext';
import type { SegmentDisplayMode } from '../../components/SegmentView';
import { RECENTER_FADE_MS } from '../../components/recenter-fade';
import { defaultScrRef, GEN_1_1_BOOK } from '../test-helpers';
import { allFalseViewOptions } from './test-helpers';

jest.mock('lucide-react', () => ({
__esModule: true,
Expand Down Expand Up @@ -519,13 +520,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -635,13 +630,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -675,13 +664,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -720,13 +703,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -742,13 +719,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -789,13 +760,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -830,13 +795,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand Down Expand Up @@ -930,13 +889,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -959,13 +912,7 @@ describe('Interlinearizer', () => {
originalTokens: [{ tokenRef: 'GEN 1:1:0', surfaceText: 'In' }],
}}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -982,13 +929,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'confirm-unlink', phraseId: 'phrase-1' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -1007,13 +948,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'edit', phraseId: 'phrase-1', originalTokens, revert: true }}
setPhraseMode={setPhraseMode}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -1032,13 +967,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'edit', phraseId: 'phrase-1', originalTokens: [], revert: true }}
setPhraseMode={setPhraseMode}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>,
),
);
Expand All @@ -1056,13 +985,7 @@ describe('Interlinearizer', () => {
analysisLanguage: 'und',
phraseMode: { kind: 'view' } as const,
setPhraseMode: () => {},
viewOptions: {
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
},
viewOptions: { ...allFalseViewOptions },
};
const { container, rerender } = render(
withNav(
Expand Down Expand Up @@ -1128,13 +1051,7 @@ describe('Interlinearizer', () => {
analysisLanguage="und"
phraseMode={{ kind: 'view' }}
setPhraseMode={() => {}}
viewOptions={{
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
}}
viewOptions={{ ...allFalseViewOptions }}
/>
);
}
Expand Down Expand Up @@ -1163,13 +1080,7 @@ describe('Interlinearizer', () => {
scrRef: { book: 'GEN', chapterNum: 1, verseNum: 1 },
phraseMode: { kind: 'view' } as const,
setPhraseMode: () => {},
viewOptions: {
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
},
viewOptions: { ...allFalseViewOptions },
};
const { container, rerender } = render(
withNav(<Interlinearizer {...props} continuousScroll={false} />),
Expand Down
10 changes: 2 additions & 8 deletions src/__tests__/components/SegmentView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { LINK_SLOT_TRANSITION_MS } from '../../components/PhraseStripParts';
import { SegmentView } from '../../components/SegmentView';
import type { ViewOptions } from '../../types/view-options';
import { makePhraseLink } from '../test-helpers';
import { withAnalysisStore } from './test-helpers';
import { allFalseViewOptions, withAnalysisStore } from './test-helpers';

// ---------------------------------------------------------------------------
// AnalysisStore mock — pass-through provider so AnalysisStore.tsx stays out of scope
Expand Down Expand Up @@ -213,13 +213,7 @@ function requiredProps(): {
tokenSegmentMap: new Map(),
tokenDocOrder: new Map(),
wordTokenByRef: new Map(),
viewOptions: {
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
},
viewOptions: { ...allFalseViewOptions },
};
}

Expand Down
10 changes: 10 additions & 0 deletions src/__tests__/components/test-helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import type { ReactNode } from 'react';
import { AnalysisStoreProvider } from '../../components/AnalysisStore';
import { ViewOptions } from '../../types/view-options';

/**
* Testing Library render options that wrap a subject in `AnalysisStoreProvider` with the default
Expand All @@ -15,3 +16,12 @@ export const withAnalysisStore = {
return <AnalysisStoreProvider analysisLanguage="und">{children}</AnalysisStoreProvider>;
},
};

/** A {@link ViewOptions} object with every toggle set to `false`, for use as a test baseline. */
export const allFalseViewOptions: ViewOptions = {
hideInactiveLinkButtons: false,
simplifyPhrases: false,
chapterLabelInVerse: false,
showMorphology: false,
showFreeTranslation: false,
};