Adding new canvas public API sample JSON data#1322
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
=========================================
Coverage 74.91% 74.91%
- Complexity 4129 4130 +1
=========================================
Files 443 443
Lines 12791 12791
Branches 1319 1319
=========================================
+ Hits 9582 9583 +1
+ Misses 2441 2440 -1
Partials 768 768 ☔ View full report in Codecov by Sentry. |
seratch
approved these changes
Jun 11, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Thanks for working on these! Once all my comments are resolved, you can merge these at any time. I will work on the full e2e tests tomorrow in my timezone
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembled by pinging the relevant APIs on Slack dev. Planned to be released tomorrow.
slackapi/node-slack-sdk#1813 on the node side had the response shapes generated based off of this PR.