Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
+ Coverage 81.62% 81.76% +0.13%
==========================================
Files 35 35
Lines 7684 7742 +58
Branches 316 316
==========================================
+ Hits 6272 6330 +58
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
srajiang
approved these changes
Jun 12, 2024
Contributor
srajiang
left a comment
There was a problem hiding this comment.
The tester script and instructs are much appreciated!
I think we could even start making a habit of sharing manifest setups to make getting configured for testing even smoother (ended up needing to add scopes). Here's mine:
This also forced me to update my terribly out of date node version to boot 🙇 🚀
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds several new Canvas APIs: create, edit, delete, sections.lookup, access.delete, access.set and conversations.canvases.create.
The response shapes were generated using slackapi/java-slack-sdk#1322
Manual Testing
To give this PR a try, check out this branch locally, then you can add a
test.tsto thepackages/web-apidirectory that is the following code. It exercises the various Canvas APIs: creates a canvas, sets access on it, looks up sections on it, edits it, and finally deletes it. You will need to export aSLACK_BOT_TOKENenvironment variable before running it, that is a bot token with at leastcanvases:write,canvases:readandfiles:readscopes. This script code executes against the dev environment. Finally, make sure to adjust the channel and user IDs at the top of the script to match a channel and user ID in the workspace you are testing in.You can run it with
npx tsx test.ts: