UI overhaul Phase 2b: migrate badge primitives to ui/ (MixDoctor + AnalysisResults) - #168
Merged
Merged
Conversation
…alysisResults) Second slice of retiring MeasurementPrimitives.tsx. Add two canonical primitives and migrate two of the three remaining consumers: - New ui/DeltaBadge and ui/TokenBadgeList, both thin wrappers over ui/Pill on the token palette (the off-palette info/violet/blue/teal tones are gone). - MixDoctorPanel + AnalysisResults: StatusBadge -> ui/Pill, DeltaBadge -> ui/DeltaBadge, TokenBadgeList -> ui/TokenBadgeList. Neither file imports from MeasurementPrimitives anymore. - Off-palette tone remaps at the call sites: muted -> neutral (genre / instrument / meter chips), violet -> neutral (production-technique chips). - mixDoctorPanel.test.ts: badge color assertions updated from StatusBadge's bg-*/10 strings to ui/Pill's bg-*/20. MeasurementDashboard (13 StatusBadge, the chord-tone helper, OutlinePillButton) and the DAW-lane primitives migrate in 2c/2d, where MeasurementPrimitives.tsx is finally deleted. Verified: lint:style, tsc --noEmit, 830 unit tests, and the production build all green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016to3B8Hf9eAGxAbzpQNvku
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2b of the UI overhaul — retire
MeasurementPrimitives.tsx(slice 2 of 3)Follows #167 (Phase 2a). Migrates the badge/chip exports onto
ui/Pill, adding two small canonical primitives, and clears two of the three remaining consumers.Change
ui/DeltaBadgeandui/TokenBadgeList— thin wrappers overui/Pillon the token palette. The off-paletteinfo/violet/blue/tealtones from the old layer are gone.MixDoctorPanel+AnalysisResults:StatusBadge→ui/Pill,DeltaBadge→ui/DeltaBadge,TokenBadgeList→ui/TokenBadgeList. Neither file imports fromMeasurementPrimitivesanymore.muted→neutral(genre / instrument / meter chips),violet→neutral(production-technique chips).mixDoctorPanel.test.ts: the three badge-color assertions move fromStatusBadge'sbg-*/10strings toui/Pill'sbg-*/20.Deferred to 2c / 2d
MeasurementDashboard(13StatusBadge, thechordToneForLabelhelper — where minor-chordvioletbecomesneutralwith a comment — andOutlinePillButton→Button) lands in 2c; the DAW-lane primitives move intoui/with tokenized colors in 2d, whereMeasurementPrimitives.tsxis deleted.Verification
npm run lint:style✓npm run lint(tsc --noEmit) ✓npm run test:unit✓ (830)npm run build✓Invariants
Presentation-layer only; no measurement/citation/data-contract surface touched.
data-text-rolehooks preserved. New primitives ship without speculative API surface (mirror the exact props their call sites use).🤖 Generated with Claude Code
Generated by Claude Code