UI overhaul Phase 2d: promote DAW-lane primitives to ui/, delete MeasurementPrimitives - #170
Merged
Merged
Conversation
…urementPrimitives Final slice of Phase 2 — the competing MeasurementPrimitives.tsx layer is now deleted; ui/ is the single primitive layer. - New ui/Lane.tsx (LaneContainer, LaneRow, TimeRuler, StatsBar) tokenizes the lane chrome: the raw #1a1a1a/#222/#252525/#1e1e1e/#2a2a2a/#333 shades snap to the surface-darker / surface-dark / border-light token ladder, #777/#555 text -> text-muted, and the StatsBar default value color -> var(--color-text-primary). No raw hex remains in the primitives. - HarmonyLanes + StructureLanes import the lanes from ./ui (their own viz hex is unchanged — they are not under the ui/ hex rule). - Add ui/Lane Storybook story (convention; Chromatic covers it). - Fix the now-stale MeasurementPrimitives reference in ConfidenceBandBadge's comment. - Delete apps/ui/src/components/MeasurementPrimitives.tsx. Verified: lint:style, tsc --noEmit, 830 unit tests, and the production build all green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016to3B8Hf9eAGxAbzpQNvku
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2d of the UI overhaul — retire
MeasurementPrimitives.tsx(final slice)Completes Phase 2 (#167, #168, #169). The competing
MeasurementPrimitives.tsxprimitive layer is deleted —src/components/ui/is now the single primitive layer.Change
ui/Lane.tsx(LaneContainer,LaneRow,TimeRuler,StatsBar) — the DAW arrangement-lane vocabulary, with tokenized chrome: the raw#1a1a1a/#222/#252525/#1e1e1e/#2a2a2a/#333shades snap to thesurface-darker/surface-dark/border-lighttoken ladder,#777/#555text →text-muted, and theStatsBardefault value color →var(--color-text-primary). No raw hex remains in the primitives (required, sinceui/is under the hex guard).HarmonyLanes+StructureLanesimport the lanes from./ui. Their own per-chord/segment viz hex is unchanged — those components compute colors and aren't under theui/hex rule.ui/LaneStorybook story added (convention; Chromatic covers it).MeasurementPrimitivesmention inConfidenceBandBadge's comment.apps/ui/src/components/MeasurementPrimitives.tsx(−565 lines).Phase 2 complete
The off-palette tone system (
info/violet/blue/teal) is fully eliminated; every badge/metric/table/lane now renders through the canonicalui/primitives on the token palette. Net −425 lines.Verification
npm run lint:style✓npm run lint(tsc --noEmit) ✓npm run test:unit✓ (830)npm run build✓Invariants
Presentation-layer only; no measurement/citation/data-contract surface touched;
data-text-rolehooks preserved.🤖 Generated with Claude Code
Generated by Claude Code