fix: stabilize flaky costumes integration test (#447)#448
Merged
Conversation
Add waitForLoadingFinished() after opening the costume library modal to handle slow library loading in CI. Increase jest.setTimeout from 60s to 90s as additional safety margin. Fixes #447 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🚀 Preview deployed: https://smalruby.jp/smalruby3-editor/fix/flaky-costumes-test-447/ |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 4, 2026
…tumes-test-447 fix: stabilize flaky costumes integration test (#447)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jest.setTimeoutfrom 60s to 90s for costume integration tests to handle CI resource contentionwaitForLoadingFinished()after opening the costume library modal in two tests that interact with library contentsChanges Made
jest.setTimeout(90_000)— gives more headroom on slow CI runnerswaitForLoadingFinished()between opening modal and searchingwaitForLoadingFinished()between opening modal and clicking filterTest Coverage
waitForLoadingFinished()is a no-op if loading is already completeFixes #447