Skip to content

fix: stabilize flaky costumes integration test (#447) #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takaokouji merged 1 commit into from
Apr 4, 2026
Merged

fix: stabilize flaky costumes integration test (#447) #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/scratch-gui/test/integration/costumes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const {
} = new SeleniumHelper();

// The costumes library is slow to load. Increase the timeout for these tests.
jest.setTimeout(60_000);
jest.setTimeout(90_000);

const uri = path.resolve(__dirname, '../../build/index.html');

Expand All @@ -35,6 +35,7 @@ describe('Working with costumes', () => {
await loadUri(uri);
await clickText('Costumes');
await clickXpath('//button[@aria-label="Choose a Costume"]');
await waitForLoadingFinished();
const el = await findByXpath("//input[@placeholder='Search']");
await el.sendKeys('abb');
await clickText('Abby-a'); // Should close the modal, then click the costumes in the selector
Expand Down Expand Up @@ -194,6 +195,7 @@ describe('Working with costumes', () => {
.setSize(1244, 768); // Letters filter not visible at 1024 width
await clickText('Costumes');
await clickXpath('//button[@aria-label="Choose a Costume"]');
await waitForLoadingFinished();
await clickText('Letters');
await clickText('Block-a', scope.modal); // Closes modal
await rightClickText('Block-a', scope.costumesTab); // Make sure it is there
Expand Down
Loading