chore: remove solana MCMS state views#22630
Merged
Merged
Conversation
These MCMS state views were not being used. Only CCIP generates MCMS state views for solana, and they have their own view generation.
Contributor
|
✅ No conflicts with other open PRs targeting |
|
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
This PR removes Solana-specific MCMS “state view” generation code from the shared deployment view/state packages, aligning with the note that CCIP is the only Solana consumer and it generates its own views.
Changes:
- Removed Solana MCMS-with-timelock view types and generators from
deployment/common/view/v1_0. - Removed the Solana MCMS-with-timelock state wrapper (and its
GenerateView) fromdeployment/common/changeset/state. - Removed the associated (flaky, skipped) Solana state view test.
Targeted areas for scrupulous human review:
- Confirm this removal is acceptable from a compatibility standpoint if
deployment/common/view/v1_0is considered part of a supported/public API surface (exported Go symbols were removed). - Confirm CCIP’s Solana view generation fully covers any remaining operational needs (since shared Solana view helpers are now gone).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deployment/common/view/v1_0/mcms.go | Removes Solana MCMS/timelock view structs and generator functions; trims imports accordingly. |
| deployment/common/changeset/state/solana.go | Deletes Solana MCMS-with-timelock state wrapper that generated the removed Solana view. |
| deployment/common/changeset/state/solana_test.go | Deletes the Solana view generation test that exercised the removed state/view code. |
ecPablo
approved these changes
May 25, 2026
jkongie
added a commit
to smartcontractkit/cld-changesets
that referenced
this pull request
May 25, 2026
BREAKING CHANGE: Removes the Solana MCMS state views from the public API. These were only being imported by tests in the chainlink repo, and these tests are being removed in smartcontractkit/chainlink#22630
gustavogama-cll
approved these changes
May 25, 2026
ChrisAmora
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These MCMS state views were not being used.
Only CCIP generates MCMS state views for solana, and they have their own view generation.