feat!: remove Solana MCMS state views#69
Conversation
BREAKING CHANGE: Removes the Solana MCMS state views from the public API.
|
👋 jkongie, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Removes the Solana MCMS “state view” helpers/types from the repository’s public Go API surface, aligning with the stated breaking change.
Changes:
- Deleted the Solana MCMS + timelock view structs and generator functions from
pkg/contract/mcms/view/v1_0. - Removed the legacy Solana
MCMSWithTimelockPrograms.GenerateViewmethod that depended on those public view types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/contract/mcms/view/v1_0/mcms.go | Removes all Solana view types/generators, leaving only EVM view support in this versioned view package. |
| legacy/pkg/family/solana/state.go | Drops the legacy GenerateView method that returned the removed Solana view type, and cleans up imports accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
BREAKING CHANGE: Removes the Solana MCMS state views from the public API.
These were only being imported by tests in the chainlink repo, and these tests are being removed in
smartcontractkit/chainlink#22630