feat: enable json and sarif output formats for secrets [PS-588]#6803
Merged
CatalinSnyk merged 1 commit intoMay 20, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
b50d89f to
4cb25b7
Compare
This comment has been minimized.
This comment has been minimized.
4cb25b7 to
d9155f8
Compare
This comment has been minimized.
This comment has been minimized.
d9155f8 to
82bb316
Compare
This comment has been minimized.
This comment has been minimized.
d09940d to
54da15a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
54da15a to
e80fc79
Compare
This comment has been minimized.
This comment has been minimized.
43d45fe to
202561b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
202561b to
2b3822d
Compare
This comment has been minimized.
This comment has been minimized.
2b3822d to
1bd8178
Compare
This comment has been minimized.
This comment has been minimized.
CatalinSnyk
reviewed
May 19, 2026
CatalinSnyk
reviewed
May 19, 2026
| } | ||
| }); | ||
| // TODO: Re-enable once SARIF and JSON WIP outputs are finalized [PS-533] | ||
| it.skip('should correctly render multiple ignores and their metadata in the output', async () => { |
Contributor
There was a problem hiding this comment.
suggestion: I think for this ones we can just follow what we did for code: we import the project into the testing org and have 2-3 ignored issues that we expect for our tests. We can tackle this as a follow up
Contributor
Author
There was a problem hiding this comment.
Okay, I will log a follow-up ticket for this, thank you.
1bd8178 to
3b4f143
Compare
This comment has been minimized.
This comment has been minimized.
CatalinSnyk
approved these changes
May 19, 2026
3b4f143 to
b308844
Compare
This comment has been minimized.
This comment has been minimized.
b308844 to
f44b091
Compare
PR Reviewer Guide 🔍
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Bumps
cli-extension-secretsto a version that ships JSON and SARIF output forsnyk secrets test, and turns on the acceptance tests that were previously skipped while those outputs were in progress.Where should the reviewer start?
test/jest/acceptance/snyk-secrets/snyk-secrets-test-user-journey.spec.ts— un-skipped tests + assertion fixes.How should this be manually tested?
https://github.com/leaktk/fake-leaksat366ae0080cc67973619584080fc85734ba2658b2../snyk secrets test <repo> --sarifand confirm a valid SARIF payload (results havefingerprints.identity, multi-location grouping is present).--jsonand--sarif-file-output=out.json.should enrich SARIF with suppressions when ignores exist).What's the product update that needs to be communicated to CLI users?
N/A
Risk assessment (Low | Medium | High)?
Low — this PR only enables acceptance coverage for already-shipping behavior.
Any background context you want to provide?
What are the relevant tickets?
Screenshots (if appropriate)