feat: add acceptance tests for secrets ignore output [PS-669]#6832
Draft
alexandru-manea-snyk wants to merge 1 commit into
Draft
feat: add acceptance tests for secrets ignore output [PS-669]#6832alexandru-manea-snyk wants to merge 1 commit into
alexandru-manea-snyk wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
alexandru-manea-snyk
force-pushed
the
feat/PS-669/acceptance-tests-secrets-with-ignores
branch
2 times, most recently
from
52e6625 to
e5aaa08
Compare
alexandru-manea-snyk
force-pushed
the
feat/PS-669/acceptance-tests-secrets-with-ignores
branch
from
e5aaa08 to
c11dc55
Compare
CatalinSnyk
reviewed
May 25, 2026
| }); | ||
| }); | ||
|
|
||
| it('omits ignored findings by default', async () => { |
Contributor
There was a problem hiding this comment.
SARIF includes all the issues by default (thus ignores are always presented), only human-readable makes use of --include-ignores
CatalinSnyk
reviewed
May 25, 2026
|
|
||
| describe('with ignored issues', () => { | ||
| // The folder below provides enough varied findings to ignore | ||
| const ignoresScanPath = `${TEMP_LOCAL_PATH}/semgrep-rules-examples`; |
Contributor
There was a problem hiding this comment.
suggestion: I think this might actually not behave as expected from my local testing: I think this gets evaluated before the beforeAll and causes the tests to fail, so I think it might be better to just compute the path in the command lines:
secrets test `${TEMP_LOCAL_PATH}/semgrep-rules-examples` --include-ignores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR adds acceptance tests for secrets ignore output in both human-readable and SARIF formats.
Where should the reviewer start?
test/jest/acceptance/snyk-secrets/snyk-secrets-test-user-journey.spec.ts: the newdescribe('with ignored issues')block and thecheckSarifhelper.How should this be manually tested?
What's the product update that needs to be communicated to CLI users?
N/A
Risk assessment (Low | Medium | High)?
Low - extends the existing test suite for secrets.
Any background context you want to provide?
This change implements the follow-up testing strategy from #6803. By ignoring select secrets findings at the org level, the tests can now successfully validate against those expected ignored issues.
What are the relevant tickets?
Screenshots (if appropriate)
N/A