Skip to content

[iOS] Fix duplicated testID #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-bert merged 2 commits into from
May 22, 2026
Merged

[iOS] Fix duplicated testID #4186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d97179
Fix duplicated testID
m-bert May 21, 2026
b3c65aa
Add if
m-bert May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/react-native-gesture-handler/apple/RNGestureHandlerButtonComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,19 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
}

[super updateProps:props oldProps:oldProps];

#if !TARGET_OS_TV && !TARGET_OS_OSX
// super's updateProps sets self.accessibilityIdentifier from testID via the
// standard Fabric mechanism. However, setAccessibilityProps already forwards
// testID to _buttonView.accessibilityIdentifier (the actual button element).
// Having the identifier on both views causes testing frameworks (e.g. Detox)
// to report multiple matches for the same testID. Clear it from the wrapper so
// only _buttonView carries the identifier.
if (!newProps.testId.empty()) {
self.accessibilityIdentifier = nil;
}
Comment thread
m-bert marked this conversation as resolved.
#endif

if (shouldApplyStartAnimationState) {
[_buttonView applyStartAnimationState];
}
Expand Down
Loading