Skip to content

[iOS] Fix duplicated testID#4186

Merged
m-bert merged 2 commits into
mainfrom
@mbert/duplicated-testid
May 22, 2026
Merged

[iOS] Fix duplicated testID#4186
m-bert merged 2 commits into
mainfrom
@mbert/duplicated-testid

Conversation

@m-bert

@m-bert m-bert commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes duplicated testID prop on iOS. Same accessibilityLabel was assigned to both, wrapper and button, therefore frameworks like Detox failed due to multiple elements with the same ID.

Fixes #3698

Test plan

Tested on branch with e2e tests.

Copilot AI review requested due to automatic review settings May 21, 2026 09:07
@m-bert m-bert mentioned this pull request May 21, 2026
Closed
Copilot AI reviewed May 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an iOS/Fabric issue where testID was applied to both the wrapper component view and the underlying button, causing e2e frameworks (e.g. Detox) to see multiple matches for a single by.id(...) query.

Changes:

  • Clears accessibilityIdentifier from the wrapper view after Fabric’s super updateProps applies testID, so only the actual _buttonView keeps the identifier.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/react-native-gesture-handler/apple/RNGestureHandlerButtonComponentView.mm
@m-bert m-bert requested a review from Copilot May 21, 2026 09:17
Copilot AI reviewed May 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@m-bert m-bert requested a review from j-piasecki May 22, 2026 08:27
@m-bert m-bert merged commit 7feab6e into main May 22, 2026
7 checks passed
@m-bert m-bert deleted the @mbert/duplicated-testid branch May 22, 2026 09:48
@m-bert m-bert mentioned this pull request Jun 11, 2026
Merged
m-bert added a commit that referenced this pull request Jun 11, 2026
@m-bert @javache
@zoontek @j-piasecki @kitten @prashanFOMO
[Release 2.32] Cherry-pick thread (#4255)
4afdcbd 
## Description

Cherry pick thread for release 2.32

## List of PRs

| PR  | Original commit |  Picked commit | Without confilct | 
|:----------:|:-------------:|:------:|:--------:|
| [[Android] Remove
`getChildInDrawingOrderAtIndex`](#4156)
|
[f1f09bc](f1f09bc)
|
[d76f2d9](d76f2d9)
| ❌ |
| [[iOS] Fix duplicated
`testID`](#4186)
|
[7feab6e](7feab6e)
|
[d1173ec](d1173ec)
| ❌ |
| [[Android] Fix discrete gestures not triggering
`onFinalize`](#4196)
|
[117087e](117087e)
|
[06212cf](06212cf)
| ✅ |
| [[Android] Fix wrong reported number of
pointers](#4218)
|
[f17bcbd](f17bcbd)
|
[5fd30f6](5fd30f6)
| ❌ |
| [fix(pods): Fix invalid `react-native/../react-native` resolution for
aliases](#4232)
|
[9a9f8b4](9a9f8b4)
|
[cacf6c0](cacf6c0)
| ✅ |
| [Move ruby utils to
module](#4245)
|
[62d0d52](62d0d52)
|
[3884f30](3884f30)
| ❌ |
| [[iOS] Fix handler retrieval and mismatched coordinate
space](#4199)
|
[b1da40b](b1da40b)
|
[2b48a8e](2b48a8e)
| ❌ |
| [[iOS] Don't iterate to root while resolving
recognizer](#4202)
|
[fba4dcc](fba4dcc)
|
[b81f2aa](b81f2aa)
| ❌ |
| [Support React Native
0.86](#4166)
|
[96dfc00](96dfc00)
|
[7df6d1a](7df6d1a)
| ❌ |
| [Fix `RNRenderer` import for React Native
0.86](#4160)
|
[0417378](0417378)
|
[6775d33](6775d33)
| ❌ |
| [Bump `expo` to stable
56](#4227)
|
[45e6ac8](45e6ac8)
|
[0478bb5](0478bb5)
| ❌ |
| [[macOS] Bump example
app](#3993)
|
[8ec0820](8ec0820)
|
[cfc5dd4](cfc5dd4)
| ❌ |
| [Bump
Reanimated](#4040)
|
[23d96d9](23d96d9)
|
[a2101eb](a2101eb)
| ❌ |
| [fix(Android): apply `numberOfPointers` config to the pointer
requirement in
`LongPressGestureHandler`](#4253)
|
[a70c6e3](a70c6e3)
|
[af40f9b](af40f9b)
| ✅ |

## Test plan

Tested that example apps are built correctly

---------

Co-authored-by: Pieter De Baets <pieter.debaets@gmail.com>
Co-authored-by: Mathieu Acthernoene <zoontek@gmail.com>
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
Co-authored-by: Phil Pluckthun <phil@kitten.sh>
Co-authored-by: prashanFOMO <prashan@fomo.family>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@j-piasecki j-piasecki j-piasecki approved these changes

@coado coado coado approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated testID on RectButton (iOS and Fabric only)

4 participants

@m-bert @j-piasecki @coado