[General] Register mount reactions in layout effect to avoid crash on unmounted detector#4268
Draft
kosmydel wants to merge 1 commit into
Draft
Conversation
… unmounted detector Run the GestureDetector mount listener in a layout effect (matching the attach/drop phase) and bail out when the detector is no longer mounted, preventing updates to a detached detector. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GestureDetectorregistered its mount listener inuseEffect, while its attach/drop lifecycle runs inuseIsomorphicLayoutEffect. Running in different phases meant the listener could fire after the detector unmounted, doing work against a detached detector (and occasionally crashing infindNodeHandle).This moves the listener to
useIsomorphicLayoutEffect(same phase as attach/drop) and adds a guard that bails out whenstate.isMountedisfalse.Credit to @hannojg for the original fix. This PR upstreams it into the main repository
Test plan
yarn ts-check,yarn lint:js, andyarn testpass.