Skip to content

[General] Register mount reactions in layout effect to avoid crash on unmounted detector #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kosmydel wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Draft

[General] Register mount reactions in layout effect to avoid crash on unmounted detector #4268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...s/react-native-gesture-handler/src/handlers/gestures/GestureDetector/useMountReactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useEffect } from 'react';

import { MountRegistry } from '../../../mountRegistry';
import { useIsomorphicLayoutEffect } from '../../../useIsomorphicLayoutEffect';
import { transformIntoHandlerTags } from '../../utils';
import type { GestureRef } from '../gesture';
import type { AttachedGestureState } from './types';
Expand All @@ -26,8 +25,14 @@ export function useMountReactions(
updateDetector: () => void,
state: AttachedGestureState
) {
useEffect(() => {
useIsomorphicLayoutEffect(() => {
return MountRegistry.addMountListener((gesture) => {
// The detector may already be unmounted when this fires; bail out to avoid
// updating a detached detector.
if (!state.isMounted) {
return;
}

// At this point the ref in the gesture config should be updated, so we can check if one of the gestures
// set in a relation with the gesture got mounted. If so, we need to update the detector to propagate
// the changes to the native side.
Expand Down
Loading