Merge solidus_starter_frontend into the monorepo by jarednorman · Pull Request #6468 · solidusio/solidus

jarednorman · 2026-04-27T14:27:27Z

Summary

As the Starter Frontend has replace solidus_frontend as the primary frontend of Solidus, we want to bring it into monorepo. This helps centralize the maintenance of the project and surface compatibility issues as early as possible.

I have chosen to preserve the whole history of the project, so the PR looks a little scary. In reality, only the merge commit that merges the other history in and subsequent commits need to be reviewed.

In the order details page shown for the confirmation step and the order complete page the billing address should be more visually related to the payment.

Also show the payment state, near the payment.

Code readability and (basic) UX improvements

Probably a legacy of an older layout.

For parity with the new card / payment method partials in which the radio buttons are external to the partials provided by the payment methods.

In a real world scenario this would probably hold instructions on where to send the check. This work both as a placeholder and to visually balance the check with other payment methods.

Only useful to remember how the numbers are distributed while testing.

The triple level of radio buttons that was previously used was very confusing and broken. Instead of trying to fix it seems better to present the customer a single list of options for making the payment. The list gives precedence to wallet payments as they require less clicks. If no wallet payments are available the first payment method is selected. Whenever a radio is selected elements from the other list are deselected, giving the illusion of having a single list. Each existing and new payment method have clear and distinct areas for the input label and for the details. This gives more symmetry between existing and new payments partial implementations and a cleaner visual layout.

…anup Payment step cleanup

enable localizing shopping cart review page

feat: localizing cart review page

Otherwise, payment iframes will still be clickable Co-authored-by: Elia Schito <elia@schito.me> Co-authored-by: Francesco Aiello <francesco.aiello@hey.com>

…ointer-events-none-to-disabled-fields Block clicks on disabled form elements

- Only render the currency microdata when the price is present - Keep the cache block in the products grid - Add specs for rendering with/without a taxon Co-Authored-By: Safa <aballaghsafa@gmail.com>

Useful for newly created stores and for testing extensions. Only track coverage on Ruby 3.2 which supports ERB files.

Track spec coverage with codecov

They were commented out for quickly trying out an alternative configuration but never removed before the merge of solidusio#329.

Restore commented out CI jobs

This makes it more consistent and recognizable.

…d-component Turn the product-card partial into a component

Rename spec_helper and allow using the debugger with bin/dev

The specs on `solidus_starter_frontend` were failing due to recent improvements with taxon/taxonomy factories made in the solidus repository, specifically related to: solidusio#4851 This commit updates the specs to be compatible with the latest changes and ensures that the test suite passes successfully.

We want to support additional keyword arguments to this class and a positional argument interferes with this. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Noah Silvera <noah@super.gd>

This association is autosaved, and Rails knows not to retouch things when autosaving associated records. I did a test to confirm that removing this doesn't change whether the field is persisted.

This condition adds a promotion condition that allows store owners to trigger a benefit if the revenue from a defined set of taxons exceeds some value. For example, with this condition we can do things like: If you spend 150 USD on pants, you get a free belt.

This fixes an edge case, a taxon condition without any taxons defined. Prior to this commit, that would error on MySQL and Postgres.

SimpleCov must start before the app is loaded (Ruby's Coverage only tracks files required after Coverage.start), so we load it from the top of the generated spec_helper.rb rather than from spec/support, which is required after rails_helper has already (eager-)loaded the app.

None of the paypal controllers in this extension had tests, which is causing the code coverage to be under the solidus required limit. This should get us to the minimum 89% code coverage to get the build green. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd> Co-authored-by: Noah Silvera <noah@super.gd>

houndci-bot · 2026-06-11T18:03:16Z

+
+  if (termsCheckbox) {
+    const form = termsCheckbox.closest('form');
+    const submitButton = form.querySelector('[type="submit"]');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-11T18:03:16Z

+  const termsCheckbox = document.getElementById('accept_terms_and_conditions');
+
+  if (termsCheckbox) {
+    const form = termsCheckbox.closest('form');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-11T18:03:16Z

+};
+
+window.addEventListener('DOMContentLoaded', () => {
+  const termsCheckbox = document.getElementById('accept_terms_and_conditions');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-11T18:03:16Z

+  });
+};
+
+window.addEventListener('DOMContentLoaded', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-11T18:03:16Z

+  const form = document.querySelector('form.edit_order');
+  form.addEventListener('submit', () => {
+    const elements = form.querySelectorAll('[type="submit"], [type="image"]');
+    elements.forEach(element => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-11T18:03:16Z

+      def load_log_entries
+        @all_log_entries = Spree::LogEntry
+          .where(source: @payment)
+          .or(Spree::LogEntry.where(source: @payment.refunds))


Layout/MultilineMethodCallIndentation: Align .or with Spree::LogEntry on line 107.

houndci-bot · 2026-06-11T18:03:16Z


+      def load_log_entries
+        @all_log_entries = Spree::LogEntry
+          .where(source: @payment)


Layout/MultilineMethodCallIndentation: Align .where with Spree::LogEntry on line 107.

houndci-bot · 2026-06-11T18:03:16Z

+      if gem_version && !gem_version.prerelease?
+        "v#{gem_version.segments[0, 2].join(".")}"
+      else
+        "main"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T18:03:16Z

+
+    ref =
+      if gem_version && !gem_version.prerelease?
+        "v#{gem_version.segments[0, 2].join(".")}"


Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

houndci-bot · 2026-06-11T18:03:16Z

+template =
+  ENV["SOLIDUS_STOREFRONT_TEMPLATE"] ||
+  begin
+    version = Spree.solidus_version if defined?(Spree) && Spree.respond_to?(:solidus_version)


Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2026-06-11T18:03:39Z

+# frozen_string_literal: true
+
+template =
+  ENV["SOLIDUS_STOREFRONT_TEMPLATE"] ||


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T18:03:39Z

-        shipments = Spree::Config.stock.coordinator_class.new(@order, @reimbursement_objects.map(&:build_exchange_inventory_unit)).shipments
+        shipments = Spree::Config.stock.coordinator_class.new(
+          @order,
+          inventory_units: @reimbursement_objects.map(&:build_exchange_inventory_unit)


Metrics/LineLength: Line is too long. [86/80]

houndci-bot · 2026-06-11T18:03:39Z

+      inventory_units = Spree::Config.stock.inventory_unit_builder_class.new(self).missing_units_for_line_item(line_item)

-      Spree::Config.stock.coordinator_class.new(self, units).shipments.each do |shipment|
+      Spree::Config.stock.coordinator_class.new(self, inventory_units:).shipments.each do |shipment|


Lint/Syntax: unexpected token tRPAREN

houndci-bot · 2026-06-11T18:03:39Z

+            (line_item.variant.product.classifications.map(&:taxon_id) & taxon_and_descendant_ids).any?
+          end
+        end
+        matching.sum(&:discounted_amount).public_send(OPERATORS.fetch(preferred_operator), preferred_amount)


Metrics/LineLength: Line is too long. [108/80]

houndci-bot · 2026-06-11T18:03:39Z

+      def order_eligible?(order, _options = {})
+        matching = order.line_items.select do |line_item|
+          taxon_ids_with_children.any? do |taxon_and_descendant_ids|
+            (line_item.variant.product.classifications.map(&:taxon_id) & taxon_and_descendant_ids).any?


Metrics/LineLength: Line is too long. [103/80]

houndci-bot · 2026-06-11T18:03:39Z

+module SolidusPromotions
+  module InMemoryOrderUpdaterPatch
+    # This is only needed for stores upgrading from the legacy promotion system.
+    # Once we've removed support for the legacy promotion system, we can remove this.


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2026-06-11T18:03:39Z

+# frozen_string_literal: true
+
+module SolidusPromotions
+  module InMemoryOrderUpdaterPatch


Style/Documentation: Missing top-level module documentation comment.

houndci-bot · 2026-06-11T18:03:39Z

      "SolidusPromotions::Conditions::PriceTaxon",
-      "SolidusPromotions::Conditions::PriceOptionValue"
+      "SolidusPromotions::Conditions::PriceOptionValue",
+      "SolidusPromotions::Conditions::TaxonRevenue"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T18:03:39Z

      "SolidusPromotions::Conditions::PriceProduct",
      "SolidusPromotions::Conditions::PriceTaxon",
-      "SolidusPromotions::Conditions::PriceOptionValue"
+      "SolidusPromotions::Conditions::PriceOptionValue",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T18:03:39Z

+require "rails_helper"
+
+RSpec.describe SolidusPromotions::Conditions::TaxonRevenue do
+  subject(:condition) { described_class.new(preferred_amount:, taxons: [matching_taxon]) }


Lint/Syntax: unexpected token tCOMMA
Lint/Syntax: unexpected token tRPAREN

houndci-bot · 2026-06-11T19:05:54Z

+  gem "guard-shell"
+
+  gem "codecov"
+  gem "simplecov", "~> 0.22"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:54Z

+  gem "guard"
+  gem "guard-shell"
+
+  gem "codecov"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:54Z

+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"
+  gem "guard-shell"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:54Z

+
+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:54Z

+gem "state_machines", "<= 0.6"
+
+group :development do
+  gem "benchmark", "~> 0.5", require: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+      next unless path.end_with?(".erb")
+
+      # Remove the extra trailing lines added by ERB
+      coverage[:lines] = coverage[:lines][...File.read(path).lines.size]


Lint/Syntax: unexpected token tDOT3
Lint/Syntax: unexpected token tRBRACK

houndci-bot · 2026-06-11T19:05:55Z

+    out https://solidus.io/security.
+  TEXT
+
+  say_status :RECOMMENDED, set_color(message.tr("\n", " "), :yellow), :yellow


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  generate "rspec:install"
+end
+
+with_log["security advisory"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+end
+
+with_log["setting up rspec"] do
+  generate "rspec:install"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gsub_file "app/assets/stylesheets/application.css", "*= require_tree", "* OFF require_tree"
+end
+
+with_log["setting up rspec"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gem "guard-shell"
+
+  gem "codecov"
+  gem "simplecov", "~> 0.22"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gem "guard"
+  gem "guard-shell"
+
+  gem "codecov"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"
+  gem "guard-shell"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+
+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+gem "state_machines", "<= 0.6"
+
+group :development do
+  gem "benchmark", "~> 0.5", require: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+      next unless path.end_with?(".erb")
+
+      # Remove the extra trailing lines added by ERB
+      coverage[:lines] = coverage[:lines][...File.read(path).lines.size]


Lint/Syntax: unexpected token tDOT3
Lint/Syntax: unexpected token tRBRACK

houndci-bot · 2026-06-11T19:05:55Z

+    out https://solidus.io/security.
+  TEXT
+
+  say_status :RECOMMENDED, set_color(message.tr("\n", " "), :yellow), :yellow


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  generate "rspec:install"
+end
+
+with_log["security advisory"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+end
+
+with_log["setting up rspec"] do
+  generate "rspec:install"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gsub_file "app/assets/stylesheets/application.css", "*= require_tree", "* OFF require_tree"
+end
+
+with_log["setting up rspec"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gem "guard-shell"
+
+  gem "codecov"
+  gem "simplecov", "~> 0.22"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gem "guard"
+  gem "guard-shell"
+
+  gem "codecov"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"
+  gem "guard-shell"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+
+group :development do
+  gem "benchmark", "~> 0.5", require: false
+  gem "guard"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+gem "state_machines", "<= 0.6"
+
+group :development do
+  gem "benchmark", "~> 0.5", require: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+      next unless path.end_with?(".erb")
+
+      # Remove the extra trailing lines added by ERB
+      coverage[:lines] = coverage[:lines][...File.read(path).lines.size]


Lint/Syntax: unexpected token tDOT3
Lint/Syntax: unexpected token tRBRACK

houndci-bot · 2026-06-11T19:05:55Z

+    out https://solidus.io/security.
+  TEXT
+
+  say_status :RECOMMENDED, set_color(message.tr("\n", " "), :yellow), :yellow


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  generate "rspec:install"
+end
+
+with_log["security advisory"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+end
+
+with_log["setting up rspec"] do
+  generate "rspec:install"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:05:55Z

+  gsub_file "app/assets/stylesheets/application.css", "*= require_tree", "* OFF require_tree"
+end
+
+with_log["setting up rspec"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:06Z

+with_log["patching asset files"] do
+  append_file "config/initializers/assets.rb", "Rails.application.config.assets.precompile += ['solidus_storefront_manifest.js']"
+  append_file "config/initializers/assets.rb", "\nRails.application.config.assets.paths << Rails.root.join('app', 'assets', 'stylesheets', 'fonts')"
+  gsub_file "app/assets/stylesheets/application.css", "*= require_tree", "* OFF require_tree"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2026-06-11T19:06:06Z

+
+with_log["patching asset files"] do
+  append_file "config/initializers/assets.rb", "Rails.application.config.assets.precompile += ['solidus_storefront_manifest.js']"
+  append_file "config/initializers/assets.rb", "\nRails.application.config.assets.paths << Rails.root.join('app', 'assets', 'stylesheets', 'fonts')"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [148/80]

houndci-bot · 2026-06-11T19:06:06Z

+end
+
+with_log["patching asset files"] do
+  append_file "config/initializers/assets.rb", "Rails.application.config.assets.precompile += ['solidus_storefront_manifest.js']"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [129/80]

houndci-bot · 2026-06-11T19:06:06Z

+  ROBOTS
+end
+
+with_log["patching asset files"] do


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:06Z

+    RUBY
+  end
+
+  append_file "public/robots.txt", <<-ROBOTS.strip_heredoc


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:07Z

+
+  # Allows to skip frontend specs generation from extensions CI pipelines
+  if ENV.fetch("FRONTEND_SPECS", "all") == "all"
+    directory "spec", verbose: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:07Z

+  RUBY
+
+  # Allows to skip frontend specs generation from extensions CI pipelines
+  if ENV.fetch("FRONTEND_SPECS", "all") == "all"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:07Z

+  insert_into_file "config/environments/test.rb", "\n  config.assets.css_compressor = nil\n", after: "config.active_support.deprecation = :stderr"
+  insert_into_file "config/environments/development.rb", "\n  config.assets.css_compressor = nil\n", after: "config.active_support.deprecation = :log"
+
+  append_file "config/initializers/devise.rb", <<~RUBY


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-11T19:06:07Z

+  rake "tailwindcss:install"
+
+  insert_into_file "config/environments/test.rb", "\n  config.assets.css_compressor = nil\n", after: "config.active_support.deprecation = :stderr"
+  insert_into_file "config/environments/development.rb", "\n  config.assets.css_compressor = nil\n", after: "config.active_support.deprecation = :log"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [150/80]

houndci-bot · 2026-06-11T19:06:07Z

+  create_file "app/assets/builds/tailwind.css"
+  rake "tailwindcss:install"
+
+  insert_into_file "config/environments/test.rb", "\n  config.assets.css_compressor = nil\n", after: "config.active_support.deprecation = :stderr"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [146/80]

This will allow us to run feature specs headless by just overriding the CAPYBARA_DRIVER ENV variable by passing `selenium_chrome` as the driver. Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Alistair Norman <alistair@super.gd> Co-authored-by: Noah Silvera <noah@super.gd>

houndci-bot · 2026-06-16T21:54:16Z

+  copy_file "config/routes/storefront.rb"
+  copy_file "config/tailwind.config.js"
+  create_file "app/assets/builds/tailwind.css"
+  rake "tailwindcss:install"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:16Z

+  copy_file "config/initializers/solidus_auth_devise_unauthorized_redirect.rb"
+  copy_file "config/routes/storefront.rb"
+  copy_file "config/tailwind.config.js"
+  create_file "app/assets/builds/tailwind.css"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:16Z

+  copy_file "config/importmap.rb"
+  copy_file "config/initializers/solidus_auth_devise_unauthorized_redirect.rb"
+  copy_file "config/routes/storefront.rb"
+  copy_file "config/tailwind.config.js"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:16Z

+
+  copy_file "config/importmap.rb"
+  copy_file "config/initializers/solidus_auth_devise_unauthorized_redirect.rb"
+  copy_file "config/routes/storefront.rb"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:16Z

+  directory "public", "public"
+
+  copy_file "config/importmap.rb"
+  copy_file "config/initializers/solidus_auth_devise_unauthorized_redirect.rb"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:17Z

+    gem "ffaker", "~> 2.13"
+    gem "rubocop", "~> 1.0"
+    gem "rubocop-performance", "~> 1.5"
+    gem "rubocop-rails", "~> 2.3"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:17Z

+    gem "factory_bot_rails"
+    gem "ffaker", "~> 2.13"
+    gem "rubocop", "~> 1.0"
+    gem "rubocop-performance", "~> 1.5"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:17Z

+    gem "factory_bot", ">= 4.8"
+    gem "factory_bot_rails"
+    gem "ffaker", "~> 2.13"
+    gem "rubocop", "~> 1.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:17Z

+
+    gem "factory_bot", ">= 4.8"
+    gem "factory_bot_rails"
+    gem "ffaker", "~> 2.13"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:17Z

+    gem "rspec-activemodel-mocks", "~> 1.1.0"
+
+    gem "factory_bot", ">= 4.8"
+    gem "factory_bot_rails"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:24Z

+    gem "rails-controller-testing", "~> 1.0.5"
+    gem "rspec-activemodel-mocks", "~> 1.1.0"
+
+    gem "factory_bot", ">= 4.8"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:24Z

+  gem_group :development, :test do
+    gem "rspec-rails"
+    gem "rails-controller-testing", "~> 1.0.5"
+    gem "rspec-activemodel-mocks", "~> 1.1.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:24Z

+
+  gem_group :development, :test do
+    gem "rspec-rails"
+    gem "rails-controller-testing", "~> 1.0.5"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:24Z

+  end
+
+  gem_group :development, :test do
+    gem "rspec-rails"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:25Z

+    gem "capybara-screenshot", "~> 1.0"
+
+    gem "simplecov", require: false
+    gem "simplecov-cobertura", require: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:25Z

+  gem "tailwindcss-rails", "~> 3.0"
+
+  gem_group :test do
+    # We need to add capybara along with a javascript driver to support the provided system specs.


Metrics/LineLength: Line is too long. [98/80]

houndci-bot · 2026-06-16T21:54:25Z

+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"
+  gem "view_component", "~> 3.0"
+  gem "tailwindcss-rails", "~> 3.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:25Z

+
+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"
+  gem "view_component", "~> 3.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:25Z

+  end
+
+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:25Z

+    generate "solidus:auth:install"
+  end
+
+  gem "responders"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+    gem "rails-controller-testing", "~> 1.0.5"
+    gem "rspec-activemodel-mocks", "~> 1.1.0"
+
+    gem "factory_bot", ">= 4.8"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+  gem_group :development, :test do
+    gem "rspec-rails"
+    gem "rails-controller-testing", "~> 1.0.5"
+    gem "rspec-activemodel-mocks", "~> 1.1.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+
+  gem_group :development, :test do
+    gem "rspec-rails"
+    gem "rails-controller-testing", "~> 1.0.5"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+  end
+
+  gem_group :development, :test do
+    gem "rspec-rails"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+    gem "capybara-screenshot", "~> 1.0"
+
+    gem "simplecov", require: false
+    gem "simplecov-cobertura", require: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+  gem "tailwindcss-rails", "~> 3.0"
+
+  gem_group :test do
+    # We need to add capybara along with a javascript driver to support the provided system specs.


Metrics/LineLength: Line is too long. [98/80]

houndci-bot · 2026-06-16T21:54:26Z

+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"
+  gem "view_component", "~> 3.0"
+  gem "tailwindcss-rails", "~> 3.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+
+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"
+  gem "view_component", "~> 3.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+  end
+
+  gem "responders"
+  gem "solidus_support", ">= 0.12.0"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:26Z

+    generate "solidus:auth:install"
+  end
+
+  gem "responders"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:31Z

+with_log["installing gems"] do
+  unless Bundler.locked_gems.dependencies["solidus_auth_devise"]
+    bundle_command "add solidus_auth_devise"
+    generate "solidus:auth:install"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:31Z

+
+with_log["installing gems"] do
+  unless Bundler.locked_gems.dependencies["solidus_auth_devise"]
+    bundle_command "add solidus_auth_devise"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:31Z

+end
+
+with_log["installing gems"] do
+  unless Bundler.locked_gems.dependencies["solidus_auth_devise"]


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:31Z

+  source_paths.unshift(templates_dir)
+end
+
+with_log["installing gems"] do


Metrics/BlockLength: Block has too many lines. [29/25]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:31Z

+
+    templates_dir = Pathname.new(repo_dir).join("storefront", "templates")
+  else
+    templates_dir = Pathname.new(File.dirname(__FILE__)).join("templates")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:32Z

+    unless match
+      say_status :error, shell.set_color(
+        "Could not parse storefront template URL: #{__FILE__}\n" \
+        "Expected shape: https://github.com/<owner>/<repo>/raw/<ref>/storefront/template.rb",


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2026-06-16T21:54:32Z

+  if __FILE__.match?(%r{\Ahttps?://})
+    require "uri"
+    url_path = URI.parse(__FILE__).path
+    match = url_path.match(%r{\A/([^/]+)/([^/]+)/raw/(.+?)/starter_frontend/template\.rb\z})


Metrics/LineLength: Line is too long. [92/80]

houndci-bot · 2026-06-16T21:54:32Z

+  require "securerandom"
+
+  if __FILE__.match?(%r{\Ahttps?://})
+    require "uri"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:32Z

+# In that case, use `git clone` to download them to a local temporary dir.
+with_log["fetching remote templates"] do
+  require "shellwords"
+  require "securerandom"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-16T21:54:32Z

+# invoked remotely via HTTP, that means the files are not present locally.
+# In that case, use `git clone` to download them to a local temporary dir.
+with_log["fetching remote templates"] do
+  require "shellwords"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

The specs we copied didn't really add any coverage to the PayPal controllers in the extension, so this change starts work on actually testing the PayPal checkout flow.

houndci-bot · 2026-06-24T21:11:23Z

+# copy_file and template resolve against our source files. If this file was
+# invoked remotely via HTTP, that means the files are not present locally.
+# In that case, use `git clone` to download them to a local temporary dir.
+with_log["fetching remote templates"] do


Metrics/BlockLength: Block has too many lines. [29/25]
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-24T21:11:23Z

+      "You are installing solidus_storefront on an outdated Ruby version.\n" \
+      "Please keep in mind that some features might not work with it.", :bold
+    ), :red
+    exit 1 if auto_accept || no?("Do you wish to proceed?")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-24T21:11:23Z

+  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.7")
+    say_status :unsupported, shell.set_color(
+      "You are installing solidus_storefront on an outdated Ruby version.\n" \
+      "Please keep in mind that some features might not work with it.", :bold


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-24T21:11:23Z

+    exit 1
+  end
+
+  if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.7")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2026-06-24T21:11:23Z

+  if Rails.gem_version < Gem::Version.new("7.0")
+    say_status :error, shell.set_color(
+      "You are trying to install solidus_storefront on an outdated Rails version.\n" \
+      "This installation attempt has been aborted, please retry using at least Rails 7.", :bold


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [95/80]

houndci-bot · 2026-06-24T21:11:23Z

+        selects.forEach(sel => sel.setAttribute('disabled', true));
+      } else {
+        addressInputs.forEach(addressInput => addressInput.style.display = 'block');
+        inputs.forEach(input => input.removeAttribute('disabled'));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:23Z

+        inputs.forEach(input => input.setAttribute('disabled', true));
+        selects.forEach(sel => sel.setAttribute('disabled', true));
+      } else {
+        addressInputs.forEach(addressInput => addressInput.style.display = 'block');


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:23Z

+      if (order_use_billing.checked) {
+        addressInputs.forEach(addressInput => addressInput.style.display = 'none');
+        inputs.forEach(input => input.setAttribute('disabled', true));
+        selects.forEach(sel => sel.setAttribute('disabled', true));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:23Z

+      const selects = document.querySelectorAll('#shipping .address-inputs select');
+      if (order_use_billing.checked) {
+        addressInputs.forEach(addressInput => addressInput.style.display = 'none');
+        inputs.forEach(input => input.setAttribute('disabled', true));


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:23Z

+      const inputs = document.querySelectorAll('#shipping .address-inputs input');
+      const selects = document.querySelectorAll('#shipping .address-inputs select');
+      if (order_use_billing.checked) {
+        addressInputs.forEach(addressInput => addressInput.style.display = 'none');


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:31Z

+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');
+      const inputs = document.querySelectorAll('#shipping .address-inputs input');
+      const selects = document.querySelectorAll('#shipping .address-inputs select');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+
+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');
+      const inputs = document.querySelectorAll('#shipping .address-inputs input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+    });
+
+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+      update_shipping_form_state(orderUseBilling);
+    });
+
+    function update_shipping_form_state(order_use_billing) {


Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.

houndci-bot · 2026-06-24T21:11:31Z

+      element.dispatchEvent(new Event('change'));
+    });
+
+    const orderUseBilling = document.getElementById('order_use_billing');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);
+        statesWithBlank.forEach(state => {
+          const selectOption = document.createElement('option');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+        const selected = parseInt(stateSelect.value);
+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);
+        statesWithBlank.forEach(state => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:32Z

+      if (states.length > 0) {
+        const selected = parseInt(stateSelect.value);
+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+      const stateInput = stateContainer.querySelector('input');
+
+      if (states.length > 0) {
+        const selected = parseInt(stateSelect.value);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+      const states = stateData.states;
+
+      const stateSelect = stateContainer.querySelector('select');
+      const stateInput = stateContainer.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');
+      const inputs = document.querySelectorAll('#shipping .address-inputs input');
+      const selects = document.querySelectorAll('#shipping .address-inputs select');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+
+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');
+      const inputs = document.querySelectorAll('#shipping .address-inputs input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+    });
+
+    function update_shipping_form_state(order_use_billing) {
+      const addressInputs = document.querySelectorAll('#shipping .address-inputs');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:31Z

+      update_shipping_form_state(orderUseBilling);
+    });
+
+    function update_shipping_form_state(order_use_billing) {


Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.

houndci-bot · 2026-06-24T21:11:31Z

+      element.dispatchEvent(new Event('change'));
+    });
+
+    const orderUseBilling = document.getElementById('order_use_billing');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);
+        statesWithBlank.forEach(state => {
+          const selectOption = document.createElement('option');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+        const selected = parseInt(stateSelect.value);
+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);
+        statesWithBlank.forEach(state => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:32Z

+      if (states.length > 0) {
+        const selected = parseInt(stateSelect.value);
+        stateSelect.innerHTML = '';
+        const statesWithBlank = [{ name: '', id: ''}].concat(states);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+      const stateInput = stateContainer.querySelector('input');
+
+      if (states.length > 0) {
+        const selected = parseInt(stateSelect.value);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:32Z

+      const states = stateData.states;
+
+      const stateSelect = stateContainer.querySelector('select');
+      const stateInput = stateContainer.querySelector('input');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:46Z

+      const statesRequired = stateData.states_required;
+      const states = stateData.states;
+
+      const stateSelect = stateContainer.querySelector('select');


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:47Z

+      }
+
+      const statesRequired = stateData.states_required;
+      const states = stateData.states;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:47Z

+        return;
+      }
+
+      const statesRequired = stateData.states_required;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:47Z

+    }
+
+    function fillStates(stateContainer, countryId) {
+      const stateData = statesCache[countryId];


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2026-06-24T21:11:47Z

+        });
+    }
+
+    function fillStates(stateContainer, countryId) {


Function declarations should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.

houndci-bot · 2026-06-24T21:11:47Z

@@ -0,0 +1,124 @@
+window.addEventListener('DOMContentLoaded', () => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:47Z

+    });
+
+    if(variantsThumbnailsToDisplay.length) {
+      const variantFirstImage = variantsThumbnailsToDisplay[0].querySelector('a').href


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

houndci-bot · 2026-06-24T21:11:47Z

+      thumbnail.style.display = 'none';
+    });
+
+    variantsThumbnailsToDisplay.forEach(thumbnail => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:47Z

+    const selector = "[data-js='variant-thumbnail'][data-js-id='" + variantId + "']";
+    const variantsThumbnailsToDisplay = document.querySelectorAll(selector);
+
+    variantsThumbnails.forEach(thumbnail => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2026-06-24T21:11:47Z

+
+  function updateVariantImages(variantId) {
+    const selector = "[data-js='variant-thumbnail'][data-js-id='" + variantId + "']";
+    const variantsThumbnailsToDisplay = document.querySelectorAll(selector);


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

elia and others added 30 commits February 16, 2023 16:48

Split checkout checks on order state and payment presence

032a91f

Show the billing address near to the payment info in the order details

1c9673e

In the order details page shown for the confirmation step and the order complete page the billing address should be more visually related to the payment.

Always show the amount covered by payments in the order details

fdb8f15

Also show the payment state, near the payment.

Merge pull request solidusio#301 from solidusio/elia/payments-fixes

b3360c7

Code readability and (basic) UX improvements

Support alternative ports via bin/dev -p 3001

77d356c

Don't use table elements inside the existing cards li

f067360

Probably a legacy of an older layout.

Extract the radio input to the existing cards partial

32d01e2

For parity with the new card / payment method partials in which the radio buttons are external to the partials provided by the payment methods.

Add a simple description to the check payment method

643e74a

In a real world scenario this would probably hold instructions on where to send the check. This work both as a placeholder and to visually balance the check with other payment methods.

Add a placeholder to the credit card number

378d10c

Only useful to remember how the numbers are distributed while testing.

Merge pull request solidusio#321 from solidusio/elia/payment-step-cle…

60ea6ab

…anup Payment step cleanup

feat: localizing cart review page

d844f56

enable localizing shopping cart review page

Merge pull request solidusio#323 from mtatheonly/patch-1

bcb9bd6

feat: localizing cart review page

Block clicks on disabled elements

d8fb74a

Otherwise, payment iframes will still be clickable Co-authored-by: Elia Schito <elia@schito.me> Co-authored-by: Francesco Aiello <francesco.aiello@hey.com>

Merge pull request solidusio#326 from solidusio/francescoaiello/add-p…

7cf7e76

…ointer-events-none-to-disabled-fields Block clicks on disabled form elements

Turn the product-card partial into a component

4921291

- Only render the currency microdata when the price is present - Keep the cache block in the products grid - Add specs for rendering with/without a taxon Co-Authored-By: Safa <aballaghsafa@gmail.com>

Silence the rails deprecation on the selenium options

3e5c2f5

Simplify the "unbundled" sandbox helper

a3e9afc

Add coverage tracking with ERB support

56fc608

Useful for newly created stores and for testing extensions. Only track coverage on Ruby 3.2 which supports ERB files.

elia/coverage: [wip]

dfd9d2a

Merge pull request solidusio#329 from solidusio/elia/coverage

bb1039e

Track spec coverage with codecov

Restore commented out CI jobs

9634c37

They were commented out for quickly trying out an alternative configuration but never removed before the merge of solidusio#329.

Merge pull request solidusio#330 from solidusio/elia/coverage

d6f6c1f

Restore commented out CI jobs

Allow using remote rdbg when running bin/dev

1a2889f

End the spec helper with _spec_helper.rb

2e44a8b

This makes it more consistent and recognizable.

Add a transition files for extensions using the spec helper old name

bc3f3f2

Remove taxon support from the product card

12b687b

Merge pull request solidusio#328 from solidusio/elia+safa/product-car…

016e4fc

…d-component Turn the product-card partial into a component

Merge pull request solidusio#327 from solidusio/elia/misc-improvements

b10bd0e

Rename spec_helper and allow using the debugger with bin/dev

sofiabesenski4 and others added 6 commits June 11, 2026 10:44

Don't "persist_amounts"

fd74c07

This association is autosaved, and Rails knows not to retouch things when autosaving associated records. I did a test to confirm that removing this doesn't change whether the field is persisted.

Add TaxonRevenue condition

bcd60d2

This condition adds a promotion condition that allows store owners to trigger a benefit if the revenue from a defined set of taxons exceeds some value. For example, with this condition we can do things like: If you spend 150 USD on pants, you get a free belt.

Bugfix: Do not interpolate empty array into SQL

93289d0

This fixes an edge case, a taxon condition without any taxons defined. Prior to this commit, that would error on MySQL and Postgres.

forkata force-pushed the all-together-now branch from 6044fa3 to 61a70e8 Compare June 11, 2026 18:02

github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Jun 11, 2026

houndci-bot reviewed Jun 11, 2026

View reviewed changes

Merge branch 'main' into all-together-now

a253832

houndci-bot reviewed Jun 11, 2026

View reviewed changes

github-actions Bot removed changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Jun 11, 2026

AlistairNorman force-pushed the all-together-now branch from 9601a86 to b7f4ad6 Compare June 16, 2026 21:54

houndci-bot reviewed Jun 16, 2026

View reviewed changes

Start working on a proper PayPal spec

50d6111

The specs we copied didn't really add any coverage to the PayPal controllers in the extension, so this change starts work on actually testing the PayPal checkout flow.

AlistairNorman force-pushed the all-together-now branch from b7f4ad6 to 50d6111 Compare June 24, 2026 21:11

houndci-bot reviewed Jun 24, 2026

View reviewed changes

		@@ -0,0 +1,124 @@
		window.addEventListener('DOMContentLoaded', () => {

Uh oh!

Uh oh!

Conversation

jarednorman commented Apr 27, 2026

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!