This repository was archived by the owner on Mar 5, 2026. It is now read-only.
Improve action discoverability by adding Cody: prefix in Search Everywhere#1872
Merged
Merged
Conversation
pkukielka
changed the title
odisseus
approved these changes
Jul 3, 2024
| group.InternalsStatusBarActions.text=?? Internals | ||
|
|
||
| # Authentication Actions | ||
| action.Cody.Accounts.LogInToSourcegraphAction.text=Log In to Sourcegraph |
Contributor
There was a problem hiding this comment.
I think it is better to keep these strings in a properties file for the sake of internationalisation, but this is more of a theoretical concern.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Maybe the i18n is not a good reason but keeping all user-facing strings in one place seems to be a rational objective.
steveyegge
pushed a commit
that referenced
this pull request
Jul 9, 2024
…where (#1872) Closes https://linear.app/sourcegraph/issue/CODY-2130/improve-how-actions-appear-in-shiftshift-menu ## Changes I moved action properties like `text` and `description` to `plugin.xml`. It is just easier to edit and inspect this way. To be honest, Geminit 1.5 did most of the work: > Given the following plugin.xml file and properties file, please modify plugin.xml so each action have additional propertes `text` and `description` with values from properties file. > Additionally for every action please add such tag: `<override-text place="GoToAction" text="Cody: $TEXT"/>` where `$TEXT` is taken from properties file as well. > For some actions like: `<action id="Cody.Accounts.LogInToSourcegraphAction" class="com.sourcegraph.cody.config.LogInToSourcegraphAction"/>` you may have to change them to form such as: > ``` > <action id="Cody.Accounts.LogInToSourcegraphAction" class="com.sourcegraph.cody.config.LogInToSourcegraphAction" text="Log In to Sourcegraph"> > <override-text place="GoToAction" text="Cody: Log In to Sourcegraph"/> > </action> >``` > > Please output whole content of the modified plugin.xml file. ## Test plan 1. Hit `Shift shift` 2. Type 'Cody:' 
mkondratek
added a commit
that referenced
this pull request
Jul 10, 2024
Rel: #1872 ## The error ``` java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key action.sourcegraph.disabled.description at java.base/java.util.ResourceBundle.getObject(ResourceBundle.java:564) at java.base/java.util.ResourceBundle.getString(ResourceBundle.java:521) at com.sourcegraph.common.CodyBundle.getString(CodyBundle.kt:29) at com.sourcegraph.cody.chat.actions.BaseChatAction.update(BaseChatAction.kt:31) ``` ## Test plan I am not sure. I was testing my own branch and I encountered the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/CODY-2130/improve-how-actions-appear-in-shiftshift-menu
Changes
I moved action properties like
textanddescriptiontoplugin.xml.It is just easier to edit and inspect this way.
To be honest, Geminit 1.5 did most of the work:
Test plan
Shift shift