Skip to content
This repository was archived by the owner on Mar 5, 2026. It is now read-only.

Bring back missing action description#1891

Merged
mkondratek merged 1 commit into
mainfrom
mkondratek/fix/disabled-desc
Jul 10, 2024
Merged

Bring back missing action description#1891
mkondratek merged 1 commit into
mainfrom
mkondratek/fix/disabled-desc

Conversation

@mkondratek

@mkondratek mkondratek commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rel: #1872
Fixes: #1892

The error

java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key action.sourcegraph.disabled.description
	at java.base/java.util.ResourceBundle.getObject(ResourceBundle.java:564)
	at java.base/java.util.ResourceBundle.getString(ResourceBundle.java:521)
	at com.sourcegraph.common.CodyBundle.getString(CodyBundle.kt:29)
	at com.sourcegraph.cody.chat.actions.BaseChatAction.update(BaseChatAction.kt:31)

Test plan

I am not sure. I was testing my own branch and I encountered the error.

@mkondratek mkondratek self-assigned this Jul 8, 2024
@mkondratek mkondratek enabled auto-merge (squash) July 8, 2024 15:36
pkukielka
pkukielka reviewed Jul 8, 2024
View reviewed changes
Comment thread src/main/resources/CodyBundle.properties
# Other Actions
action.cody.restartAgent.text=Restart Cody Agent
chat.enhanced_context.title=Chat Context Settings
action.sourcegraph.disabled.description=Log in to Sourcegraph to enable Cody features

@pkukielka pkukielka Jul 8, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put it in plugin.xml where all others are?

@mkondratek mkondratek Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, IntelliJ SDK does not support text for disabled actions. Maybe we should not modify the descriptions at all? Anyway, if we want to keep the desc it must remain as it is.

pkukielka
pkukielka approved these changes Jul 10, 2024
View reviewed changes

@pkukielka pkukielka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit f78d85f into main Jul 10, 2024
@mkondratek mkondratek deleted the mkondratek/fix/disabled-desc branch July 10, 2024 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@pkukielka pkukielka pkukielka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mkondratek mkondratek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JetBrains: Crash occurred after installing Cody.

2 participants

@mkondratek @pkukielka