set scale factor in the object as well#14
Open
binomaiheu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
First of all thanks for this library (and allowing me to add some "advanced" telemetry to the kids' waterrocket :)) I noticed when playing with the setScale() function, that the readings for getCalculatedX(), etc changed by a similar factor, which I assume shouldn't happen as they are in units of g.
Shouldn't the the "scale" factor also be set in the setScale() function in addition to the hardware configuration of the sensor itself ? That way the scale is correctly taken into account in the getCalculatedX(), .... functions. Or perhaps I'm missing something.
Cheers,
bino