Skip to content

Add SKE login command #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vicentepinto98 merged 19 commits into from
May 16, 2024
Merged

Add SKE login command #157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1e838b6
Add SKE login command
Jan 31, 2024
eab1147
Different improvement from code review
Apr 12, 2024
4133c99
remove unused function
Apr 16, 2024
97027cf
rearrange functions and improve error messages
Apr 16, 2024
c7e29d0
Add tests for cache pkg
Apr 16, 2024
e01baa2
Extend kubeconfig create command with flag to retrieve login kubeconfig
May 14, 2024
9658d01
small extension to the kubeconfig login description
May 14, 2024
8df5e65
improve descriptions and examples
May 15, 2024
0e5b6a5
fix yaml output
May 15, 2024
3675a67
codereview: use os.UserCacheDir instead of external lib
May 15, 2024
512fce2
codereview: drop parseInput and use parseClusterConfig directly; move…
May 15, 2024
e5967d7
codereview: add one nil check
May 15, 2024
a890a22
codereview: print user facing error that explains that the login comm…
May 15, 2024
483a02f
fixup! codereview: use os.UserCacheDir instead of external lib
May 15, 2024
fc69d74
codereview: first try at improving the description
May 15, 2024
e7f832a
generate-docs
May 15, 2024
f5977f9
Add tests for login (buildRequest & parseKubeConfigToExecCredential
May 16, 2024
db10e3e
cache: call Init func directly and return err
May 16, 2024
ff04ac2
use p.Outputf instead of cmd.Print
May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve descriptions and examples
  • Loading branch information
Kai Kummerer committed May 15, 2024
commit 8df5e651ab914da28db627d9a9e3eca7c53f1dce
4 changes: 2 additions & 2 deletions internal/cmd/ske/kubeconfig/create/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ func NewCmd(p *print.Printer) *cobra.Command {
`Create a kubeconfig for the SKE cluster with name "my-cluster"`,
"$ stackit ske kubeconfig create my-cluster"),
examples.NewExample(
`Create a login kubeconfig for the SKE cluster with name "my-cluster".`,
"This kubeconfig does not contain any credentials and instead obtains valid credentials via the STACKIT CLI",
`Get a login kubeconfig for the SKE cluster with name "my-cluster". `+
"This kubeconfig does not contain any credentials and instead obtains valid credentials via the STACKIT CLI.",
"$ stackit ske kubeconfig create my-cluster --login"),
examples.NewExample(
`Create a kubeconfig for the SKE cluster with name "my-cluster" and set the expiration time to 30 days`,
Expand Down
18 changes: 13 additions & 5 deletions internal/cmd/ske/kubeconfig/login/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,21 @@ const (
func NewCmd(p *print.Printer) *cobra.Command {
cmd := &cobra.Command{
Use: "login",
Short: "login plugin for kubectl",
Long: "login plugin for kubectl to create a short-lived kubeconfig to authenticate against a STACKIT Kubernetes Engine (SKE) cluster. To obtain a kubeconfig for use with the login command, use the 'kubeconfig create --login' command.",
Args: args.NoArgs,
Short: "Login plugin for kubernetes clients",
Long: fmt.Sprintf("%s\n%s",
"Login plugin for kubernetes clients, that creates short-lived credentials to authenticate against a STACKIT Kubernetes Engine (SKE) cluster.",
"To obtain a kubeconfig for use with the login command, run 'kubeconfig create --login'.",
),
Args: args.NoArgs,
Example: examples.Build(
examples.NewExample(
"login to a SKE cluster specified in the kubeconfig",
"$ kubectl get pod"),
`Get a login kubeconfig for the SKE cluster with name "my-cluster". `+
"This kubeconfig does not contain any credentials and instead obtains valid credentials via the STACKIT CLI.",
"$ stackit ske kubeconfig create my-cluster --login"),
examples.NewExample(
"Use the previously saved kubeconfig to authenticate to the SKE cluster, in this case with kubectl.",
"$ kubectl cluster-info",
"$ kubectl get pods"),
),
RunE: func(cmd *cobra.Command, args []string) error {
ctx := context.Background()
Expand Down