-
Notifications
You must be signed in to change notification settings - Fork 32
Add SKE login command #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vicentepinto98
merged 19 commits into
stackitcloud:main
from
Kumm-Kai:feature/kubectl-login
May 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1e838b6
Add SKE login command
eab1147
Different improvement from code review
4133c99
remove unused function
97027cf
rearrange functions and improve error messages
c7e29d0
Add tests for cache pkg
e01baa2
Extend kubeconfig create command with flag to retrieve login kubeconfig
9658d01
small extension to the kubeconfig login description
8df5e65
improve descriptions and examples
0e5b6a5
fix yaml output
3675a67
codereview: use os.UserCacheDir instead of external lib
512fce2
codereview: drop parseInput and use parseClusterConfig directly; move…
e5967d7
codereview: add one nil check
a890a22
codereview: print user facing error that explains that the login comm…
483a02f
fixup! codereview: use os.UserCacheDir instead of external lib
fc69d74
codereview: first try at improving the description
e7f832a
generate-docs
f5977f9
Add tests for login (buildRequest & parseKubeConfigToExecCredential
db10e3e
cache: call Init func directly and return err
ff04ac2
use p.Outputf instead of cmd.Print
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add tests for cache pkg
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,195 @@ | ||
| package cache | ||
|
|
||
| import ( | ||
| "errors" | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/adrg/xdg" | ||
| "github.com/google/uuid" | ||
| ) | ||
|
|
||
| func TestGetObject(t *testing.T) { | ||
| tests := []struct { | ||
| description string | ||
| identifier string | ||
| expectFile bool | ||
| expectedErr error | ||
| }{ | ||
| { | ||
| description: "identifier exists", | ||
| identifier: "test-cache-get-exists", | ||
| expectFile: true, | ||
| expectedErr: nil, | ||
| }, | ||
| { | ||
| description: "identifier does not exist", | ||
| identifier: "test-cache-get-not-exists", | ||
| expectFile: false, | ||
| expectedErr: os.ErrNotExist, | ||
| }, | ||
| { | ||
| description: "identifier is invalid", | ||
| identifier: "in../../valid", | ||
| expectFile: false, | ||
| expectedErr: ErrorInvalidCacheIdentifier, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.description, func(t *testing.T) { | ||
| id := tt.identifier + "-" + uuid.NewString() | ||
|
|
||
| // setup | ||
| if tt.expectFile { | ||
| err := createFolderIfNotExists(cacheFolderPath) | ||
| if err != nil { | ||
| t.Fatalf("create cache folder: %s", err.Error()) | ||
| } | ||
| path := cacheFolderPath + "/" + id | ||
| if err := os.WriteFile(path, []byte("dummy"), 0o600); err != nil { | ||
| t.Fatalf("setup: WriteFile (%s) failed", path) | ||
| } | ||
| } | ||
| // test | ||
| file, err := GetObject(id) | ||
|
|
||
| if !errors.Is(err, tt.expectedErr) { | ||
| t.Fatalf("returned error (%q) does not match %q", err.Error(), tt.expectedErr.Error()) | ||
| } | ||
|
|
||
| if tt.expectFile { | ||
| if len(file) < 1 { | ||
| t.Fatalf("expected a file but byte array is empty (len %d)", len(file)) | ||
| } | ||
| } else { | ||
| if len(file) > 0 { | ||
| t.Fatalf("didn't expect a file, but byte array is not empty (len %d)", len(file)) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
| func TestPutObject(t *testing.T) { | ||
| // Also test createFolderIfNotExists here | ||
| tests := []struct { | ||
| description string | ||
| identifier string | ||
| existingFile bool | ||
| expectFile bool | ||
| expectedErr error | ||
| customPath string | ||
| }{ | ||
| { | ||
| description: "identifier already exists", | ||
| identifier: "test-cache-put-exists", | ||
| existingFile: true, | ||
| expectFile: true, | ||
| expectedErr: nil, | ||
| }, | ||
| { | ||
| description: "identifier does not exist", | ||
| identifier: "test-cache-put-not-exists", | ||
| expectFile: true, | ||
| expectedErr: nil, | ||
| }, | ||
| { | ||
| description: "identifier is invalid", | ||
| identifier: "in../../valid", | ||
| expectFile: false, | ||
| expectedErr: ErrorInvalidCacheIdentifier, | ||
| }, | ||
| { | ||
| description: "directory does not yet exist", | ||
| identifier: "test-cache-put-folder-not-exists", | ||
| expectFile: true, | ||
| expectedErr: nil, | ||
| customPath: "/tmp/stackit-cli-test", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.description, func(t *testing.T) { | ||
| id := tt.identifier + "-" + uuid.NewString() | ||
| if tt.customPath != "" { | ||
| cacheFolderPath = tt.customPath | ||
| } else { | ||
| cacheFolderPath = xdg.CacheHome | ||
| } | ||
| path := cacheFolderPath + "/" + id | ||
|
|
||
| // setup | ||
| if tt.existingFile { | ||
| if err := os.WriteFile(path, []byte("dummy"), 0o600); err != nil { | ||
| t.Fatalf("setup: WriteFile (%s) failed", path) | ||
| } | ||
| } | ||
| // test | ||
| err := PutObject(id, []byte("dummy")) | ||
|
|
||
| if !errors.Is(err, tt.expectedErr) { | ||
| t.Fatalf("returned error (%q) does not match %q", err.Error(), tt.expectedErr.Error()) | ||
| } | ||
|
|
||
| if tt.expectFile { | ||
| if _, err := os.Stat(path); errors.Is(err, os.ErrNotExist) { | ||
| t.Fatalf("expected file (%q) to exist", path) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestDeleteObject(t *testing.T) { | ||
| tests := []struct { | ||
| description string | ||
| identifier string | ||
| existingFile bool | ||
| expectedErr error | ||
| }{ | ||
| { | ||
| description: "identifier exists", | ||
| identifier: "test-cache-delete-exists", | ||
| existingFile: true, | ||
| expectedErr: nil, | ||
| }, | ||
| { | ||
| description: "identifier does not exist", | ||
| identifier: "test-cache-delete-not-exists", | ||
| existingFile: false, | ||
| expectedErr: nil, | ||
| }, | ||
| { | ||
| description: "identifier is invalid", | ||
| identifier: "in../../valid", | ||
| existingFile: false, | ||
| expectedErr: ErrorInvalidCacheIdentifier, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.description, func(t *testing.T) { | ||
| id := tt.identifier + "-" + uuid.NewString() | ||
| path := cacheFolderPath + "/" + id | ||
|
|
||
| // setup | ||
| if tt.existingFile { | ||
| if err := os.WriteFile(path, []byte("dummy"), 0o600); err != nil { | ||
| t.Fatalf("setup: WriteFile (%s) failed", path) | ||
| } | ||
| } | ||
| // test | ||
| err := DeleteObject(id) | ||
|
|
||
| if !errors.Is(err, tt.expectedErr) { | ||
| t.Fatalf("returned error (%q) does not match %q", err.Error(), tt.expectedErr.Error()) | ||
| } | ||
|
|
||
| if tt.existingFile { | ||
| if _, err := os.Stat(path); !errors.Is(err, os.ErrNotExist) { | ||
| t.Fatalf("expected file (%q) to not exist", path) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.