Skip to content

Validate weights fix#350

Merged
paul-buerkner merged 2 commits into
stan-dev:masterfrom
n-kall:validate_weights-fix
Mar 6, 2024
Merged

Validate weights fix#350
paul-buerkner merged 2 commits into
stan-dev:masterfrom
n-kall:validate_weights-fix

Conversation

@n-kall
Copy link
Copy Markdown
Collaborator

@n-kall n-kall commented Mar 6, 2024

Summary

Fixes #347 by not allowing missing values in weights.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner paul-buerkner merged commit 5403ae5 into stan-dev:master Mar 6, 2024
@paul-buerkner
Copy link
Copy Markdown
Collaborator

thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 00bf4da is merged into master:

  •   :ballot_box_with_check:as_draws_array: 142ms -> 142ms [-1.34%, +1.36%]
  •   :ballot_box_with_check:as_draws_df: 71.8ms -> 71.4ms [-1.29%, +0.33%]
  •   :ballot_box_with_check:as_draws_list: 173ms -> 172ms [-1.28%, +0.61%]
  • ❗🐌as_draws_matrix: 62.9ms -> 65.1ms [+2.34%, +4.69%]
  •   :ballot_box_with_check:as_draws_rvars: 85ms -> 84.6ms [-1.6%, +0.84%]
  •   :ballot_box_with_check:summarise_draws_100_variables: 712ms -> 712ms [-0.33%, +0.42%]
  •   :ballot_box_with_check:summarise_draws_10_variables: 116ms -> 116ms [-0.91%, +1.04%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate_weights allows NaN and NA weights

2 participants