Single-draw bug fix for augmented-data and latent projection#512
Merged
fweber144 merged 1 commit intoMay 3, 2025
Merged
Conversation
a single projected draw for performance evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug for augmented-data and latent projection when using a single projected draw for performance evaluation in
cv_varsel()withcv_method = "LOO"andvalidate_search = FALSE. Reprex:This bug is fixed here by adding
drop = FALSEto the relevant matrix subsetting operations. In theory, a similar bug could occur for analogous reference model quantities (that's whydrop = FALSEis added there, too), but this is only a theoretical problem as a reference model with a single draw is unlikely to occur in practice.A
NEWS.mdentry is still missing here. I will add it as soon as #511 (or #508) has been merged. I would propose the following text for such aNEWS.mdentry (under "Bug fixes"):