Verbosity enhancements#518
Merged
Merged
Conversation
PSIS-LOO CV or K-fold CV with `validate_search = TRUE`); these messages mention the observation/fold for which computations are currently taking place. Also rename `verbose_search` to `verbose_obs` (in `one_obs()`) and `verbose_fold` (in `one_fold()`). Also use a more consistent naming of objects containing text for verbose-mode messages (`vtxt_[...]` instead of `verb_[...]`).
…sages); this makes those messages more similar to the `print.vselsummary()` output
`one_obs()` and `one_fold()` (and high verbosity)
call that is used for creating `summaries_fast`
also set `file = stderr()` in `utils::txtProgressBar()` calls (this is the behavior in the progressr package and also mentioned in the documentation of argument `file` of `utils::txtProgressBar()`)
…to `~ 1`"; this is done not only for the intercept-only model, but for all submodel formulas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up for PR #516: Thanks to #516, the PR presented here can add "extra" verbosity (i.e., when global option
projpred.extra_verboseis set toTRUE) about the current fold when runningcv_varsel()withvalidate_search = TRUEor K-fold CV withvalidate_search = FALSE. There are some other minor enhancements to verbosity which are explained in the commit messages.File
NEWS.mdis unchanged here. I will update it as soon as #511 (or #508) has been merged. I would propose to change the following entry:to: