Generate files concurrently#54
Merged
Merged
Conversation
Member
Author
|
Ah spatie/fork requires php8. 🤔 |
Member
|
Maybe it could just check if fork is installed (might need to be done separately) and if you're running PHP 8 when someone provides the additional param. Although, I'm not sure if that would work.... |
Member
Author
|
Yeah either we just bump the PHP requirement of ssg to 8, or do that. |
Member
Author
|
Okay I've made it so that you can only use concurrency if you manually install |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses Spatie's fork package to split the content file generation into as many chunks as you request. Each chunk will run at the same time.
You must have
spatie/forkinstalled, which requires PHP 8.You can specify how many "workers" should be used with an option.
Each worker will spawn a separate PHP process, so you should only use as many workers as you have CPU cores.
The console output has been adjusted a little to cope with the concurrency. Rather than output each line, you get a single line that is constantly updating, and you will see all the errors right at the end.
If you don't have
spatie/forkinstalled, it'll tell you:If you use
--workers=1(for some reason) or don't specify the option at all, it'll happily just chug along without concurrency.Fixes #16