refactor: PR #1175 refinements — remove duplicate filter, update wiki#1179
Merged
Conversation
The manual workItemCount filter in MilestonesPage duplicated the generic client-side filtering provided by DataTable's getValue prop. Also updates wiki API Contract with filterMeta documentation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.2.0-beta.26 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 25, 2026
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses refinements from product-architect review of PR #1175:
getValue. Removed the redundant code.filterMetaresponse field documentation and numeric filter query parameters (budgetLinesMin/Max,amountMin/Max,dateFrom/To,dueDateFrom/To,plannedCostMin/Max,actualCostMin/Max) to the three list endpoints.Test plan
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com