Skip to content

refactor: PR #1175 refinements — remove duplicate filter, update wiki #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steilerDev merged 1 commit into from
Mar 22, 2026
Merged

refactor: PR #1175 refinements — remove duplicate filter, update wiki #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions client/src/pages/MilestonesPage/MilestonesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,20 +169,8 @@ export function MilestonesPage() {
}
}

// Work item count filter (format: "min:X,max:Y")
const workItemCountFilter = tableState.filters.get('workItemCount')?.value;
if (workItemCountFilter) {
const minMatch = workItemCountFilter.match(/min:([\d.]+)/);
const maxMatch = workItemCountFilter.match(/max:([\d.]+)/);
const filterMin = minMatch ? parseFloat(minMatch[1]) : undefined;
const filterMax = maxMatch ? parseFloat(maxMatch[1]) : undefined;
result = result.filter((m) => {
const val = m.workItemCount ?? 0;
if (filterMin !== undefined && val < filterMin) return false;
if (filterMax !== undefined && val > filterMax) return false;
return true;
});
}
// Note: workItemCount filtering is handled by DataTable's generic
// client-side filtering via the getValue prop on the column definition.

// Sorting
if (tableState.sortBy) {
Expand Down
2 changes: 1 addition & 1 deletion wiki
Open in desktop
Submodule wiki updated from 13668e to cba40a
Loading