fix(test): resolve CI test flakiness in App.test and E2E budget-overview#196
Merged
Conversation
- Increase waitFor timeout in App.test.tsx from default 1000ms to 5000ms
to accommodate slower CI environments where React.lazy imports and auth
checks take longer to resolve
- Use specific locator `getByRole('img', { name: /Budget breakdown/ })`
in budget-overview E2E test instead of bare `getByRole('img')` which
matched both the logo SVG and BudgetBar, causing Playwright strict
mode violations
Co-Authored-By: Claude orchestrator (Opus 4.6) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.9.0-beta.39 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitFortimeout from default 1000ms to 5000ms for lazy-loading assertions. The React.lazy import + auth check chain takes longer on CI runners than locally, causing intermittent timeouts.page.getByRole('img')topage.getByRole('img', { name: /Budget breakdown/ })to avoid Playwright strict mode violation — the bare selector matched both the logo SVG and the BudgetBar component.Fixes CI failures on PR #160.
Test plan
🤖 Generated with Claude Code