Skip to content

fix(test): resolve CI test flakiness in App.test and E2E budget-overview #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steilerDev merged 1 commit into from
Feb 22, 2026
Merged

fix(test): resolve CI test flakiness in App.test and E2E budget-overview #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions client/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,18 @@ describe('App', () => {
render(<App />);
expect(document.body).toBeInTheDocument();
// Wait for auth check and lazy-loaded component to resolve
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument(), {
timeout: 5000,
});
});

it('renders the AppShell layout with sidebar and header', async () => {
render(<App />);

// Wait for auth loading to complete
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByText('Loading...')).not.toBeInTheDocument(), {
timeout: 5000,
});

// Sidebar should be present
const sidebar = screen.getByRole('complementary');
Expand Down
4 changes: 3 additions & 1 deletion e2e/tests/budget/budget-overview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,9 @@ test.describe('Budget Health Hero', { tag: '@responsive' }, () => {
await overviewPage.waitForLoaded();

// Then: The BudgetBar stacked bar chart is visible (role="img")
await expect(page.getByRole('img')).toBeVisible({ timeout: 8000 });
await expect(page.getByRole('img', { name: /Budget breakdown/ })).toBeVisible({
timeout: 8000,
});
} finally {
await page.unroute(`${API.budgetOverview}`);
}
Expand Down