OverlayV2: Add metrics for tracking tx e2e latency - #5330
Merged
marta-lokhova merged 1 commit intoJul 16, 2026
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
marta-lokhova
left a comment
marta-lokhova
left a comment
Contributor
There was a problem hiding this comment.
looks good overall! added a few questions and nits, mostly around perf
marta-lokhova
approved these changes
Jul 16, 2026
marta-lokhova
left a comment
marta-lokhova
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Feel free to squash commits and we can merge.
drebelsky
force-pushed
the
track-tx-latency
branch
from
July 16, 2026 20:59
6270660 to
ac84861
Compare
marta-lokhova
approved these changes
Jul 16, 2026
pull Bot
pushed a commit
to Bloxxix/stellar-core
that referenced
this pull request
Jul 20, 2026
Adds metrics for tracking e2e latency in testing. Same work as stellar#5330.
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per-node metrics for tracking tx e2e latency. The metrics are gated behind the config flag
LOADGEN_MEASURE_TX_LATENCY_FOR_TESTINGand are split into two kinds: per-run and cumulative. The per-run metrics are only updated at the successful completion of a loadgen run (so that there's one overall number we can use as a P50/75/99, etc...), while the cumulative numbers use a Medida timer (for more granular monitoring).