Skip to content

Add metrics for tracking tx e2e latency - #5356

Merged
marta-lokhova merged 2 commits into
stellar:masterfrom
drebelsky:track-tx-latency-v1
Jul 20, 2026
Merged

Add metrics for tracking tx e2e latency#5356
marta-lokhova merged 2 commits into
stellar:masterfrom
drebelsky:track-tx-latency-v1

Conversation

@drebelsky

@drebelsky drebelsky commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Adds metrics for tracking e2e latency in testing. Same work as #5330.

Copilot AI review requested due to automatic review settings July 16, 2026 22:31
marta-lokhova
marta-lokhova previously approved these changes Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@drebelsky

Copy link
Copy Markdown
Contributor Author

Looks like the failure was because the -Wthread-safety-analysis couldn't see that the lambdas held the mutex.

@marta-lokhova
marta-lokhova enabled auto-merge July 20, 2026 19:07
@marta-lokhova
marta-lokhova added this pull request to the merge queue Jul 20, 2026
Merged via the queue into stellar:master with commit 0c8f7dc Jul 20, 2026
68 checks passed
pull Bot pushed a commit to Mirage1348/stellar-core that referenced this pull request Jul 30, 2026
Update to stellar#5356. Changes how we get the transactions that have been
externalized from using the generated meta to using the externalized tx
set so that we can support overlay-only mode. Also, moves when the call
to `recordTxMetaEmissionLatency` happens: now, it happens after the
simulated sleep. For the overlay-only simulated delay, this is the best
time to call it. Unfortunately, this lengthens the time for the
real-delay case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants