Skip to content

Core: Fix core-common to use node-fetch #23077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 1 commit into from
Jun 14, 2023
Merged

Core: Fix core-common to use node-fetch #23077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
make core-common use node-fetch
  • Loading branch information
@ndelangen
ndelangen committed Jun 14, 2023
commit 92fabb7a58bb7e383f7b9b7d2da9738844ac9dd2
2 changes: 2 additions & 0 deletions code/lib/core-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"@storybook/types": "7.1.0-alpha.34",
"@types/find-cache-dir": "^3.2.1",
"@types/node": "^16.0.0",
"@types/node-fetch": "^2.6.4",
"@types/pretty-hrtime": "^1.0.0",
"chalk": "^4.1.0",
"esbuild": "^0.18.0",
Expand All @@ -58,6 +59,7 @@
"glob": "^10.0.0",
"handlebars": "^4.7.7",
"lazy-universal-dotenv": "^4.0.0",
"node-fetch": "^2.0.0",
"picomatch": "^2.3.0",
"pkg-dir": "^5.0.0",
"pretty-hrtime": "^1.0.3",
Expand Down
1 change: 1 addition & 0 deletions code/lib/core-common/src/utils/get-storybook-refs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { readJSON } from 'fs-extra';
import { dirname, join } from 'path';
import findUp from 'find-up';
import fetch from 'node-fetch';

import resolveFrom from 'resolve-from';
import { logger } from '@storybook/node-logger';
Expand Down
6 changes: 4 additions & 2 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6169,6 +6169,7 @@ __metadata:
"@types/find-cache-dir": ^3.2.1
"@types/mock-fs": ^4.13.1
"@types/node": ^16.0.0
"@types/node-fetch": ^2.6.4
"@types/picomatch": ^2.3.0
"@types/pretty-hrtime": ^1.0.0
chalk: ^4.1.0
Expand All @@ -6182,6 +6183,7 @@ __metadata:
handlebars: ^4.7.7
lazy-universal-dotenv: ^4.0.0
mock-fs: ^5.2.0
node-fetch: ^2.0.0
picomatch: ^2.3.0
pkg-dir: ^5.0.0
pretty-hrtime: ^1.0.3
Expand Down Expand Up @@ -8626,7 +8628,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node-fetch@npm:^2.5.7":
"@types/node-fetch@npm:^2.5.7, @types/node-fetch@npm:^2.6.4":
version: 2.6.4
resolution: "@types/node-fetch@npm:2.6.4"
dependencies:
Expand Down Expand Up @@ -22778,7 +22780,7 @@ __metadata:
languageName: node
linkType: hard

"node-fetch@npm:^2.6.1, node-fetch@npm:^2.6.7":
"node-fetch@npm:^2.0.0, node-fetch@npm:^2.6.1, node-fetch@npm:^2.6.7":
version: 2.6.11
resolution: "node-fetch@npm:2.6.11"
dependencies:
Expand Down
Loading