Add ability to include signatures with ContractTxData#462
Merged
quantumagi merged 4 commits intostratisproject:masterfrom Mar 16, 2021
Merged
Add ability to include signatures with ContractTxData#462quantumagi merged 4 commits intostratisproject:masterfrom
quantumagi merged 4 commits intostratisproject:masterfrom
Conversation
fassadlr
reviewed
Mar 16, 2021
fassadlr
reviewed
Mar 16, 2021
|
|
||
| protected void AddSignatures(List<byte[]> rlpBytes, string[] signatures) | ||
| { | ||
| if (signatures != null && signatures.Any()) |
Contributor
There was a problem hiding this comment.
Perhaps Guard null if the signatures is null or empty? Then remove the null and Any checks?
fassadlr
reviewed
Mar 16, 2021
fassadlr
reviewed
Mar 16, 2021
fassadlr
reviewed
Mar 16, 2021
fassadlr
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it possible to include signatures into the transaction that creates a SC. This will allow us to write a rule to confirm that system contracts have been signed by the required signatories before being adopted by the nodes.
See https://app.clickup.com/t/34wnfe.
This is a backwards compatible change required by system contracts.